Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Unified Diff: webrtc/media/base/videocapturer.h

Issue 2334683002: Add method cricket::VideoCapturer::NeedsDenoising, use in VideoCapturerTrackSource. (Closed)
Patch Set: TODO comment explaining the NeedsDenoising hack. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/media/base/fakevideocapturer.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/media/base/videocapturer.h
diff --git a/webrtc/media/base/videocapturer.h b/webrtc/media/base/videocapturer.h
index c9c96eeb1d299cb06eaad73c8d4734cfdc357eac..eb868d9877c0fc664b3f7fc0a042c154f74f90b6 100644
--- a/webrtc/media/base/videocapturer.h
+++ b/webrtc/media/base/videocapturer.h
@@ -175,6 +175,18 @@ class VideoCapturer : public sigslot::has_slots<>,
// implement screencast specific behavior.
virtual bool IsScreencast() const = 0;
+ // Indicates that the encoder should denoise video before encoding
+ // it, wired up to VideoCapturerTrackSource::needs_denoising. If it
+ // is not set, the default configuration is used which is different
+ // depending on video codec.
+ // TODO(nisse): This is a workaround needed to fix
+ // https://bugs.chromium.org/p/chromium/issues/detail?id=645907.
+ // Chrome should migrate to implement VideoTrackSourceInterface
+ // directly, and then this method is no longer needed.
+ virtual rtc::Optional<bool> NeedsDenoising() const {
+ return rtc::Optional<bool>();
+ }
+
// Caps the VideoCapturer's format according to max_format. It can e.g. be
// used to prevent cameras from capturing at a resolution or framerate that
// the capturer is capable of but not performing satisfactorily at.
« no previous file with comments | « webrtc/media/base/fakevideocapturer.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698