Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1306)

Side by Side Diff: webrtc/media/base/videocapturer.h

Issue 2334683002: Add method cricket::VideoCapturer::NeedsDenoising, use in VideoCapturerTrackSource. (Closed)
Patch Set: TODO comment explaining the NeedsDenoising hack. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/media/base/fakevideocapturer.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2010 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2010 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 157 matching lines...) Expand 10 before | Expand all | Expand 10 after
168 CaptureState capture_state() const { 168 CaptureState capture_state() const {
169 return capture_state_; 169 return capture_state_;
170 } 170 }
171 171
172 virtual bool apply_rotation() { return apply_rotation_; } 172 virtual bool apply_rotation() { return apply_rotation_; }
173 173
174 // Returns true if the capturer is screencasting. This can be used to 174 // Returns true if the capturer is screencasting. This can be used to
175 // implement screencast specific behavior. 175 // implement screencast specific behavior.
176 virtual bool IsScreencast() const = 0; 176 virtual bool IsScreencast() const = 0;
177 177
178 // Indicates that the encoder should denoise video before encoding
179 // it, wired up to VideoCapturerTrackSource::needs_denoising. If it
180 // is not set, the default configuration is used which is different
181 // depending on video codec.
182 // TODO(nisse): This is a workaround needed to fix
183 // https://bugs.chromium.org/p/chromium/issues/detail?id=645907.
184 // Chrome should migrate to implement VideoTrackSourceInterface
185 // directly, and then this method is no longer needed.
186 virtual rtc::Optional<bool> NeedsDenoising() const {
187 return rtc::Optional<bool>();
188 }
189
178 // Caps the VideoCapturer's format according to max_format. It can e.g. be 190 // Caps the VideoCapturer's format according to max_format. It can e.g. be
179 // used to prevent cameras from capturing at a resolution or framerate that 191 // used to prevent cameras from capturing at a resolution or framerate that
180 // the capturer is capable of but not performing satisfactorily at. 192 // the capturer is capable of but not performing satisfactorily at.
181 // The capping is an upper bound for each component of the capturing format. 193 // The capping is an upper bound for each component of the capturing format.
182 // The fourcc component is ignored. 194 // The fourcc component is ignored.
183 void ConstrainSupportedFormats(const VideoFormat& max_format); 195 void ConstrainSupportedFormats(const VideoFormat& max_format);
184 196
185 void set_enable_camera_list(bool enable_camera_list) { 197 void set_enable_camera_list(bool enable_camera_list) {
186 enable_camera_list_ = enable_camera_list; 198 enable_camera_list_ = enable_camera_list;
187 } 199 }
(...skipping 139 matching lines...) Expand 10 before | Expand all | Expand 10 after
327 bool apply_rotation_; 339 bool apply_rotation_;
328 340
329 // State for the timestamp translation. 341 // State for the timestamp translation.
330 rtc::TimestampAligner timestamp_aligner_; 342 rtc::TimestampAligner timestamp_aligner_;
331 RTC_DISALLOW_COPY_AND_ASSIGN(VideoCapturer); 343 RTC_DISALLOW_COPY_AND_ASSIGN(VideoCapturer);
332 }; 344 };
333 345
334 } // namespace cricket 346 } // namespace cricket
335 347
336 #endif // WEBRTC_MEDIA_BASE_VIDEOCAPTURER_H_ 348 #endif // WEBRTC_MEDIA_BASE_VIDEOCAPTURER_H_
OLDNEW
« no previous file with comments | « webrtc/media/base/fakevideocapturer.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698