Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 2334583002: Revert of Introduced new scheme for controlling the functionality inside the audio processing module (Closed)

Created:
4 years, 3 months ago by kjellander_webrtc
Modified:
4 years, 3 months ago
CC:
webrtc-reviews_webrtc.org, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Introduced new scheme for controlling the functionality inside the audio processing module (patchset #12 id:260001 of https://codereview.webrtc.org/2292863002/ ) Reason for revert: Interface change in the mock breaks downstream code. Original issue's description: > The current scheme for setting parameters and specifying the behavior > of the audio processing module is quite complex and hard to implement > in a threadsafe and efficient manner. Therefore a new scheme for setting > the parameters in the audio processing module is introduced in this CL. > > The idea is to roll this scheme out gradually and as a first functionality > in the audio processing module where this is applied the level controller > was chosen. This CL includes the replacement of the Config-based > level controller scheme with the new scheme. > > BUG=webrtc:5298 > > Committed: https://crrev.com/c8bbe3fe9aad9e9a1189a42dcaa8f5d6c261ecc8 > Cr-Commit-Position: refs/heads/master@{#14171} TBR=solenberg@webrtc.org,henrik.lundin@webrtc.org,peah@webrtc.org BUG=webrtc:5298 NOTRY=True Committed: https://crrev.com/10f606d8de2e81d2200dd598fcc404d8f83fcf83 Cr-Commit-Position: refs/heads/master@{#14177}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -169 lines) Patch
M webrtc/media/engine/fakewebrtcvoiceengine.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/media/engine/webrtcvoiceengine.cc View 2 chunks +1 line, -3 lines 0 comments Download
M webrtc/modules/audio_processing/audio_processing_impl.h View 4 chunks +8 lines, -8 lines 0 comments Download
M webrtc/modules/audio_processing/audio_processing_impl.cc View 5 chunks +18 lines, -34 lines 0 comments Download
M webrtc/modules/audio_processing/audio_processing_impl_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/modules/audio_processing/echo_cancellation_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_processing/echo_cancellation_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_processing/include/audio_processing.h View 5 chunks +13 lines, -28 lines 0 comments Download
M webrtc/modules/audio_processing/include/mock_audio_processing.h View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/audio_processing/level_controller/level_controller.h View 1 chunk +0 lines, -6 lines 0 comments Download
M webrtc/modules/audio_processing/level_controller/level_controller.cc View 1 chunk +0 lines, -13 lines 0 comments Download
M webrtc/modules/audio_processing/level_controller/level_controller_complexity_unittest.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M webrtc/modules/audio_processing/level_controller/level_controller_unittest.cc View 1 chunk +0 lines, -19 lines 0 comments Download
M webrtc/modules/audio_processing/test/aec_dump_based_simulator.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M webrtc/modules/audio_processing/test/audio_processing_simulator.cc View 3 chunks +1 line, -5 lines 0 comments Download
M webrtc/modules/audio_processing/test/debug_dump_test.cc View 18 chunks +23 lines, -33 lines 0 comments Download
M webrtc/modules/audio_processing/test/process_test.cc View 3 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
kjellander_webrtc
Created Revert of Introduced new scheme for controlling the functionality inside the audio processing module
4 years, 3 months ago (2016-09-12 05:16:40 UTC) #1
peah-webrtc
On 2016/09/12 05:38:01, kjellander_webrtc wrote: > Description was changed from > > ========== > Revert ...
4 years, 3 months ago (2016-09-12 05:45:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2334583002/1
4 years, 3 months ago (2016-09-12 05:56:46 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-12 06:04:35 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/10f606d8de2e81d2200dd598fcc404d8f83fcf83 Cr-Commit-Position: refs/heads/master@{#14177}
4 years, 3 months ago (2016-09-12 06:04:40 UTC) #9
hlundin-webrtc
4 years, 3 months ago (2016-09-12 08:12:39 UTC) #10
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698