Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 2331013002: Change onCameraOpening to take camera name as a parameter instead of camera id. (Closed)

Created:
4 years, 3 months ago by sakal
Modified:
4 years, 3 months ago
Reviewers:
magjed_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Change onCameraOpening to take camera name as a parameter instead of camera id. Camera id doesn't really exist for Camera2. Changing onCameraOpening to take a string instead removes ugly code. BUG=webrtc:6325 R=magjed@webrtc.org Committed: https://crrev.com/bc18fc07beb3909c632cc4dbb73370fb5ec2062b Cr-Commit-Position: refs/heads/master@{#14212}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -11 lines) Patch
M webrtc/api/android/java/src/org/webrtc/Camera2Session.java View 1 chunk +1 line, -7 lines 0 comments Download
M webrtc/api/android/java/src/org/webrtc/CameraCapturer.java View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/api/android/java/src/org/webrtc/CameraVideoCapturer.java View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/api/android/java/src/org/webrtc/VideoCapturerAndroid.java View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/api/androidtests/src/org/webrtc/CameraVideoCapturerTestFixtures.java View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 18 (12 generated)
sakal
PTAL
4 years, 3 months ago (2016-09-12 14:14:06 UTC) #1
magjed_webrtc
lgtm
4 years, 3 months ago (2016-09-13 13:30:48 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2331013002/1
4 years, 3 months ago (2016-09-13 14:15:42 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2331013002/1
4 years, 3 months ago (2016-09-14 12:34:47 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-14 12:36:24 UTC) #16
commit-bot: I haz the power
4 years, 3 months ago (2016-09-14 12:36:31 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bc18fc07beb3909c632cc4dbb73370fb5ec2062b
Cr-Commit-Position: refs/heads/master@{#14212}

Powered by Google App Engine
This is Rietveld 408576698