Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1638)

Unified Diff: webrtc/api/android/java/src/org/webrtc/Camera2Session.java

Issue 2331013002: Change onCameraOpening to take camera name as a parameter instead of camera id. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | webrtc/api/android/java/src/org/webrtc/CameraCapturer.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/api/android/java/src/org/webrtc/Camera2Session.java
diff --git a/webrtc/api/android/java/src/org/webrtc/Camera2Session.java b/webrtc/api/android/java/src/org/webrtc/Camera2Session.java
index f03bcaaed3e05c994049414dd8f6eeab7ae34b68..a10ce8f5389422d5d2434465db5529130e2defb8 100644
--- a/webrtc/api/android/java/src/org/webrtc/Camera2Session.java
+++ b/webrtc/api/android/java/src/org/webrtc/Camera2Session.java
@@ -316,13 +316,7 @@ public class Camera2Session implements CameraSession {
checkIsOnCameraThread();
Logging.d(TAG, "Opening camera " + cameraId);
- int cameraIndex = -1;
- try {
- cameraIndex = Integer.parseInt(cameraId);
- } catch (NumberFormatException e) {
- Logging.d(TAG, "External camera with non-int identifier: " + cameraId);
- }
- eventsHandler.onCameraOpening(cameraIndex);
+ eventsHandler.onCameraOpening(cameraId);
try {
cameraManager.openCamera(cameraId, new CameraStateCallback(), cameraThreadHandler);
« no previous file with comments | « no previous file | webrtc/api/android/java/src/org/webrtc/CameraCapturer.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698