Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(792)

Issue 2320043002: OWNERS: Make everyone able to change *.gn,*.gni files. (Closed)

Created:
4 years, 3 months ago by kjellander_webrtc
Modified:
4 years, 3 months ago
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), zhuangzesen_agora.io, tlegrand-webrtc, qiang.lu, peah-webrtc, bjornv1, video-team_agora.io, tterriberry_mozilla.com, fengyue_agora.io, sdk-team_agora.io, minyue-webrtc, mflodman, Andrew MacDonald, zhengzhonghou_agora.io, stefan-webrtc, kwiberg-webrtc, danilchap, henrika_webrtc, audio-team_agora.io, hlundin-webrtc, niklas.enbom, the sun, perkj_webrtc, aluebs-webrtc
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

OWNERS: Make everyone able to change *.gn,*.gni files. Project-wide change to make it possible for all team members to do changes to GN files. NOTRY=True R=kwiberg@webrtc.org TBR=henrika@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/a41c13e6a2c472512095493e1755449eec309338

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -72 lines) Patch
M webrtc/OWNERS View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/api/OWNERS View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/audio/OWNERS View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/base/OWNERS View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/build/mb_config.pyl View 1 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/call/OWNERS View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/common_audio/OWNERS View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/common_video/OWNERS View 1 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/examples/OWNERS View 1 chunk +6 lines, -1 line 0 comments Download
M webrtc/libjingle/xmllite/OWNERS View 1 chunk +6 lines, -1 line 0 comments Download
M webrtc/libjingle/xmpp/OWNERS View 1 chunk +6 lines, -1 line 0 comments Download
M webrtc/media/OWNERS View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/OWNERS View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/audio_coding/OWNERS View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/audio_conference_mixer/OWNERS View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/audio_device/OWNERS View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/audio_mixer/OWNERS View 1 chunk +6 lines, -1 line 0 comments Download
M webrtc/modules/audio_processing/OWNERS View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/bitrate_controller/OWNERS View 1 chunk +6 lines, -6 lines 0 comments Download
M webrtc/modules/congestion_controller/OWNERS View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/desktop_capture/OWNERS View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/media_file/OWNERS View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/pacing/OWNERS View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/OWNERS View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/rtp_rtcp/OWNERS View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/utility/OWNERS View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/video_capture/OWNERS View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/video_coding/OWNERS View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/video_processing/OWNERS View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/p2p/OWNERS View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/pc/OWNERS View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/sdk/OWNERS View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/stats/OWNERS View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/system_wrappers/OWNERS View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/video/OWNERS View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/voice_engine/OWNERS View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 22 (12 generated)
kjellander_webrtc
4 years, 3 months ago (2016-09-08 06:56:21 UTC) #2
kwiberg-webrtc
I presume that there is no way to do this just in the top-level file ...
4 years, 3 months ago (2016-09-08 08:05:44 UTC) #5
kjellander_webrtc
On 2016/09/08 08:05:44, kwiberg-webrtc wrote: > I presume that there is no way to do ...
4 years, 3 months ago (2016-09-08 09:52:44 UTC) #6
kwiberg-webrtc
lgtm
4 years, 3 months ago (2016-09-08 10:34:03 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2320043002/1
4 years, 3 months ago (2016-09-09 08:41:32 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/8217)
4 years, 3 months ago (2016-09-09 08:43:42 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2320043002/20001
4 years, 3 months ago (2016-09-09 11:22:30 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/8231)
4 years, 3 months ago (2016-09-09 11:25:00 UTC) #17
kjellander_webrtc
Committed patchset #2 (id:20001) manually as a41c13e6a2c472512095493e1755449eec309338 (presubmit successful).
4 years, 3 months ago (2016-09-09 12:51:55 UTC) #21
kjellander_webrtc
4 years, 3 months ago (2016-09-09 12:52:18 UTC) #22
Message was sent while issue was closed.
On 2016/09/09 11:25:00, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   presubmit on master.tryserver.webrtc (JOB_FAILED,
> http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/8231)

Not sure about this error, I think it might have been the case of Windows
linebreaks (CR+LF) on webrtc/modules/bitrate_controller/OWNERS, but it looked
correct when I checked.
I submitted manually instead.

Powered by Google App Engine
This is Rietveld 408576698