Fixing NetEqReplacementInput for reordered and missing packets

Fixing NetEqReplacementInput for reordered and missing packets

With this CL, the NetEqReplacementInput class handles reordered and
missing packets in a better way than before, by storing the last
confirmed packet size and using that when the next packet size cannot
be calculated.

NOTRY=True

Committed: https://crrev.com/243c0e80662f7cd700875df0ef3d9fa085be21f5
Cr-Commit-Position: refs/heads/master@{#14122}

[hlundin-webrtc, 2016-09-07 14:47:05]

henrik.lundin@webrtc.org changed reviewers:
+ ivoc@webrtc.org

[hlundin-webrtc, 2016-09-07 14:47:06]

Ivo, PTAL.

Thanks!

[ivoc, 2016-09-07 14:55:42]

LGTM, see one question below.

https://codereview.webrtc.org/2319553003/diff/1/webrtc/modules/audio_coding/n...
File webrtc/modules/audio_coding/neteq/tools/neteq_replacement_input.h (right):

https://codereview.webrtc.org/2319553003/diff/1/webrtc/modules/audio_coding/n...
webrtc/modules/audio_coding/neteq/tools/neteq_replacement_input.h:45: uint32_t
last_frame_size_timestamps_ = 960;
Is there any reason for choosing 960 here? A comment to explain would be
helpful.

[hlundin-webrtc, 2016-09-08 07:54:16]

Description was changed from

==========
Fixing NetEqReplacementInput for reordered and missing packets

With this CL, the NetEqReplacementInput class handles reordered and
missing packets in a better way than before, by storing the last
confirmed packet size and using that when the next packet size cannot
be calculated.
==========

to

==========
Fixing NetEqReplacementInput for reordered and missing packets

With this CL, the NetEqReplacementInput class handles reordered and
missing packets in a better way than before, by storing the last
confirmed packet size and using that when the next packet size cannot
be calculated.

NOTRY=True
==========

[hlundin-webrtc, 2016-09-08 07:55:09]

Thanks for the review. I added a comment, and added a missing #include (found by
lint).

This will be committed, pending trybots.

https://codereview.webrtc.org/2319553003/diff/1/webrtc/modules/audio_coding/n...
File webrtc/modules/audio_coding/neteq/tools/neteq_replacement_input.h (right):

https://codereview.webrtc.org/2319553003/diff/1/webrtc/modules/audio_coding/n...
webrtc/modules/audio_coding/neteq/tools/neteq_replacement_input.h:45: uint32_t
last_frame_size_timestamps_ = 960;
On 2016/09/07 14:55:42, ivoc wrote:
> Is there any reason for choosing 960 here? A comment to explain would be
> helpful.

Done.

[hlundin-webrtc, 2016-09-08 09:02:31]

The CQ bit was checked by henrik.lundin@webrtc.org

[hlundin-webrtc, 2016-09-08 09:02:31]

The patchset sent to the CQ was uploaded after l-g-t-m from ivoc@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2319553003/#ps20001 (title:
"Fixing review comment and a lint nit")

[commit-bot: I haz the power, 2016-09-08 09:06:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-09-08 09:14:30]

Description was changed from

==========
Fixing NetEqReplacementInput for reordered and missing packets

With this CL, the NetEqReplacementInput class handles reordered and
missing packets in a better way than before, by storing the last
confirmed packet size and using that when the next packet size cannot
be calculated.

NOTRY=True
==========

to

==========
Fixing NetEqReplacementInput for reordered and missing packets

With this CL, the NetEqReplacementInput class handles reordered and
missing packets in a better way than before, by storing the last
confirmed packet size and using that when the next packet size cannot
be calculated.

NOTRY=True
==========

[commit-bot: I haz the power, 2016-09-08 09:14:31]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-08 09:14:38]

Description was changed from

==========
Fixing NetEqReplacementInput for reordered and missing packets

With this CL, the NetEqReplacementInput class handles reordered and
missing packets in a better way than before, by storing the last
confirmed packet size and using that when the next packet size cannot
be calculated.

NOTRY=True
==========

to

==========
Fixing NetEqReplacementInput for reordered and missing packets

With this CL, the NetEqReplacementInput class handles reordered and
missing packets in a better way than before, by storing the last
confirmed packet size and using that when the next packet size cannot
be calculated.

NOTRY=True

Committed: https://crrev.com/243c0e80662f7cd700875df0ef3d9fa085be21f5
Cr-Commit-Position: refs/heads/master@{#14122}
==========

[commit-bot: I haz the power, 2016-09-08 09:14:39]

Patchset 2 (id:??) landed as
https://crrev.com/243c0e80662f7cd700875df0ef3d9fa085be21f5
Cr-Commit-Position: refs/heads/master@{#14122}