webrtc/modules/audio_coding/neteq/tools/neteq_replacement_input.h - Issue 2319553003: Fixing NetEqReplacementInput for reordered and missing packets

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: webrtc/modules/audio_coding/neteq/tools/neteq_replacement_input.h

Issue 2319553003: Fixing NetEqReplacementInput for reordered and missing packets (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | webrtc/modules/audio_coding/neteq/tools/neteq_replacement_input.cc » ('j') | no next file with comments »

OLD	NEW
1 /*	1 /*

2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.	2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.

3 *	3 *

4 * Use of this source code is governed by a BSD-style license	4 * Use of this source code is governed by a BSD-style license

5 * that can be found in the LICENSE file in the root of the source	5 * that can be found in the LICENSE file in the root of the source

6 * tree. An additional intellectual property rights grant can be found	6 * tree. An additional intellectual property rights grant can be found

7 * in the file PATENTS. All contributing project authors may	7 * in the file PATENTS. All contributing project authors may

8 * be found in the AUTHORS file in the root of the source tree.	8 * be found in the AUTHORS file in the root of the source tree.

9 */	9 */

10	10

(...skipping 24 matching lines...) Expand all Loading...
35 rtc::Optional<RTPHeader> NextHeader() const override;	35 rtc::Optional<RTPHeader> NextHeader() const override;

36	36

37 private:	37 private:

38 void ReplacePacket();	38 void ReplacePacket();

39	39

40 std::unique_ptr<NetEqInput> source_;	40 std::unique_ptr<NetEqInput> source_;

41 const uint8_t replacement_payload_type_;	41 const uint8_t replacement_payload_type_;

42 const std::set<uint8_t> comfort_noise_types_;	42 const std::set<uint8_t> comfort_noise_types_;

43 const std::set<uint8_t> forbidden_types_;	43 const std::set<uint8_t> forbidden_types_;

44 std::unique_ptr<PacketData> packet_; // The next packet to deliver.	44 std::unique_ptr<PacketData> packet_; // The next packet to deliver.

	45 uint32_t last_frame_size_timestamps_ = 960;
	ivoc 2016/09/07 14:55:42 Is there any reason for choosing 960 here? A comme Is there any reason for choosing 960 here? A comment to explain would be helpful. hlundin-webrtc 2016/09/08 07:55:09 Done. Show quoted text On 2016/09/07 14:55:42, ivoc wrote: > Is there any reason for choosing 960 here? A comment to explain would be > helpful. Done.
45 };	46 };

46	47

47 } // namespace test	48 } // namespace test

48 } // namespace webrtc	49 } // namespace webrtc

49 #endif // WEBRTC_MODULES_AUDIO_CODING_NETEQ_TOOLS_NETEQ_REPLACEMENT_INPUT_H_	50 #endif // WEBRTC_MODULES_AUDIO_CODING_NETEQ_TOOLS_NETEQ_REPLACEMENT_INPUT_H_

OLD	NEW