Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Unified Diff: webrtc/media/engine/webrtcvideoframe.h

Issue 2315663002: Make cricket::VideoFrame inherit webrtc::VideoFrame. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/media/engine/webrtcvideoframe.h
diff --git a/webrtc/media/engine/webrtcvideoframe.h b/webrtc/media/engine/webrtcvideoframe.h
index d0034e27cd5efc43e1505ac277bbf3005f552403..82e87cf8d509a6e6d2b81397f00cc0ccc499ca9e 100644
--- a/webrtc/media/engine/webrtcvideoframe.h
+++ b/webrtc/media/engine/webrtcvideoframe.h
@@ -22,8 +22,8 @@
namespace cricket {
-struct CapturedFrame;
-
+using WebRtcVideoFrame = VideoFrame;
+#if 0
// TODO(nisse): This class will be deleted when the cricket::VideoFrame and
// webrtc::VideoFrame classes are merged. See
// https://bugs.chromium.org/p/webrtc/issues/detail?id=5682. Try to use only the
@@ -55,6 +55,10 @@ class WebRtcVideoFrame : public VideoFrame {
~WebRtcVideoFrame();
+ // TODO(nisse): Init (and its helpers Reset and Validate) are used
+ // only by the LoadFrame function used in the VideoFrame unittests.
+ // Rewrite tests, and delete this function.
+
// Creates a frame from a raw sample with FourCC "format" and size "w" x "h".
// "h" can be negative indicating a vertically flipped image.
// "dh" is destination height if cropping is desired and is always positive.
@@ -69,15 +73,6 @@ class WebRtcVideoFrame : public VideoFrame {
int64_t timestamp_ns,
webrtc::VideoRotation rotation);
- // TODO(nisse): We're moving to have all timestamps use the same
- // time scale as rtc::TimeMicros. However, this method is used by
- // WebRtcVideoFrameFactory::CreateAliasedFrame this code path
- // currently does not conform to the new timestamp conventions and
- // may use the camera's own clock instead. It's unclear if this
- // should be fixed, or if instead all of the VideoFrameFactory
- // abstraction should be eliminated.
- bool Init(const CapturedFrame* frame, int dw, int dh, bool apply_rotation);
-
void InitToEmptyBuffer(int w, int h);
int width() const override;
@@ -124,6 +119,7 @@ class WebRtcVideoFrame : public VideoFrame {
// remains const.
mutable std::unique_ptr<VideoFrame> rotated_frame_;
};
+#endif
} // namespace cricket

Powered by Google App Engine
This is Rietveld 408576698