Make cricket::VideoFrame inherit webrtc::VideoFrame.

webrtc/video_frame.h

Index: webrtc/video_frame.h
diff --git a/webrtc/video_frame.h b/webrtc/video_frame.h
index b99e60d62113e6b6dc7b369a1597129bca0a8d94..2c5160aeac983498ac07f3624a6fda3347f92a76 100644
--- a/webrtc/video_frame.h
+++ b/webrtc/video_frame.h
@@ -18,6 +18,10 @@
 #include "webrtc/common_video/rotation.h"
 #include "webrtc/typedefs.h"
 
+namespace cricket {
+class WebRtcVideoFrameTest;
+}  // namespace cricket
+
 namespace webrtc {
 
 // TODO(nisse): This class duplicates cricket::VideoFrame. There's
@@ -185,6 +189,9 @@ class VideoFrame {
   }
 
  private:
+  // Tests mutate |rotation_|, so the base test class is a friend.
+  friend class cricket::WebRtcVideoFrameTest;

[pthatcher1, 2016/09/07 18:11:39]

A reference to a unit test class?  That seems terrible.  Why don't we just add
some kind of set_rotation method?

[nisse-webrtc, 2016/09/08 11:07:13]

No longer needed, since this cl also deletes those tests. Deleted.

For background, this friend declaration can be found in  in webrtcvideoframe.h
on master. WebRtcVideoFrame used to have a set_rotation method, used only by
tests. It was removed by sergeyu and replaced by this friend declaration, in cl
https://codereview.webrtc.org/2075983003/

+
   // An opaque reference counted handle that stores the pixel data.
   rtc::scoped_refptr<webrtc::VideoFrameBuffer> video_frame_buffer_;
   uint32_t timestamp_rtp_;