Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: webrtc/media/devices/gtkvideorenderer.h

Issue 2315663002: Make cricket::VideoFrame inherit webrtc::VideoFrame. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« webrtc/media/base/fakevideocapturer.h ('K') | « webrtc/media/base/videoframefactory.cc ('k') | webrtc/media/engine/webrtcvideocapturer.cc » ('j') | webrtc/video_frame.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/media/devices/gtkvideorenderer.h
diff --git a/webrtc/media/devices/gtkvideorenderer.h b/webrtc/media/devices/gtkvideorenderer.h
index 750a5bb8d5eac311b4235e52cf5034f8f005ddaf..0e480126ce290fff84b0a79d98ff8e9e50c3dd13 100644
--- a/webrtc/media/devices/gtkvideorenderer.h
+++ b/webrtc/media/devices/gtkvideorenderer.h
@@ -17,13 +17,18 @@
#include <memory>
#include "webrtc/base/basictypes.h"
+#include "webrtc/media/base/videoframe.h"
#include "webrtc/media/base/videosinkinterface.h"
typedef struct _GtkWidget GtkWidget; // forward declaration, defined in gtk.h
namespace cricket {
+// TODO(nisse): For some reason, forward declaration doens't work when
+// the definition is a "using" alias.
+#if 0
class VideoFrame;
+#endif
class GtkVideoRenderer : public rtc::VideoSinkInterface<VideoFrame> {
public:
« webrtc/media/base/fakevideocapturer.h ('K') | « webrtc/media/base/videoframefactory.cc ('k') | webrtc/media/engine/webrtcvideocapturer.cc » ('j') | webrtc/video_frame.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698