Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 2307563002: Added missing debug dump flags for the APM unit tests (Closed)

Created:
4 years, 3 months ago by peah-webrtc
Modified:
4 years, 3 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

In order to ensure that the same code is run in the tests as is otherwise run it is important that the same build flags are used in the code being tested. For the debugging functionality inside APM, that was not the case and this is corrected in this CL. This CL is chained to the CL https://codereview.webrtc.org/2300813004/ BUG=webrtc:5298 Committed: https://crrev.com/c435946ec117d4f2180ef5cd3244ff48ef09d32c Cr-Commit-Position: refs/heads/master@{#14031}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M webrtc/modules/BUILD.gn View 1 chunk +6 lines, -0 lines 0 comments Download
M webrtc/modules/modules.gyp View 1 chunk +5 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 24 (12 generated)
peah-webrtc
4 years, 3 months ago (2016-09-01 10:11:22 UTC) #3
kjellander_webrtc
lgtm
4 years, 3 months ago (2016-09-01 10:35:54 UTC) #5
hlundin-webrtc
lgtm
4 years, 3 months ago (2016-09-01 11:04:09 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2307563002/1
4 years, 3 months ago (2016-09-01 16:25:31 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) android_rel on ...
4 years, 3 months ago (2016-09-01 18:26:15 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2307563002/1
4 years, 3 months ago (2016-09-01 19:23:05 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
4 years, 3 months ago (2016-09-01 21:23:36 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2307563002/1
4 years, 3 months ago (2016-09-01 21:50:44 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
4 years, 3 months ago (2016-09-01 23:51:21 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2307563002/1
4 years, 3 months ago (2016-09-02 04:55:34 UTC) #20
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-02 05:03:29 UTC) #22
commit-bot: I haz the power
4 years, 3 months ago (2016-09-02 05:03:38 UTC) #24
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c435946ec117d4f2180ef5cd3244ff48ef09d32c
Cr-Commit-Position: refs/heads/master@{#14031}

Powered by Google App Engine
This is Rietveld 408576698