|
|
Created:
4 years, 3 months ago by peah-webrtc Modified:
4 years, 3 months ago CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com Target Ref:
refs/pending/heads/master Project:
webrtc Visibility:
Public. |
DescriptionIn order to ensure that the same code is run in the tests as is otherwise
run it is important that the same build flags are used in the code being
tested. For the debugging functionality inside APM, that was not the case
and this is corrected in this CL.
This CL is chained to the CL https://codereview.webrtc.org/2300813004/
BUG=webrtc:5298
Committed: https://crrev.com/c435946ec117d4f2180ef5cd3244ff48ef09d32c
Cr-Commit-Position: refs/heads/master@{#14031}
Patch Set 1 #
Depends on Patchset: Messages
Total messages: 24 (12 generated)
Description was changed from ========== Added missing debug dump flags for the apm tests. In order to ensure that the same code is run in the tests as is otherwise run it is important that the same build flags are used in the code being tested. For the debugging functionality inside APM, that was not the case and this is corrected in this CL. BUG= ========== to ========== Added missing debug dump flags for the apm tests. In order to ensure that the same code is run in the tests as is otherwise run it is important that the same build flags are used in the code being tested. For the debugging functionality inside APM, that was not the case and this is corrected in this CL. This CL is chained to the CL https://codereview.webrtc.org/2300813004/ BUG=webrtc:5298 ==========
peah@webrtc.org changed reviewers: + henrik.lundin@webrtc.org, kjellander@webrtc.org
Description was changed from ========== Added missing debug dump flags for the apm tests. In order to ensure that the same code is run in the tests as is otherwise run it is important that the same build flags are used in the code being tested. For the debugging functionality inside APM, that was not the case and this is corrected in this CL. This CL is chained to the CL https://codereview.webrtc.org/2300813004/ BUG=webrtc:5298 ========== to ========== In order to ensure that the same code is run in the tests as is otherwise run it is important that the same build flags are used in the code being tested. For the debugging functionality inside APM, that was not the case and this is corrected in this CL. This CL is chained to the CL https://codereview.webrtc.org/2300813004/ BUG=webrtc:5298 ==========
lgtm
lgtm
The CQ bit was checked by peah@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) android_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) win_clang_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) win_clang_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) win_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) win_drmemory_light on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) win_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) win_x64_clang_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) win_x64_clang_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) win_x64_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) win_x64_gyp_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) win_x64_gyp_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) win_x64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by peah@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by peah@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by peah@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
Message was sent while issue was closed.
Description was changed from ========== In order to ensure that the same code is run in the tests as is otherwise run it is important that the same build flags are used in the code being tested. For the debugging functionality inside APM, that was not the case and this is corrected in this CL. This CL is chained to the CL https://codereview.webrtc.org/2300813004/ BUG=webrtc:5298 ========== to ========== In order to ensure that the same code is run in the tests as is otherwise run it is important that the same build flags are used in the code being tested. For the debugging functionality inside APM, that was not the case and this is corrected in this CL. This CL is chained to the CL https://codereview.webrtc.org/2300813004/ BUG=webrtc:5298 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== In order to ensure that the same code is run in the tests as is otherwise run it is important that the same build flags are used in the code being tested. For the debugging functionality inside APM, that was not the case and this is corrected in this CL. This CL is chained to the CL https://codereview.webrtc.org/2300813004/ BUG=webrtc:5298 ========== to ========== In order to ensure that the same code is run in the tests as is otherwise run it is important that the same build flags are used in the code being tested. For the debugging functionality inside APM, that was not the case and this is corrected in this CL. This CL is chained to the CL https://codereview.webrtc.org/2300813004/ BUG=webrtc:5298 Committed: https://crrev.com/c435946ec117d4f2180ef5cd3244ff48ef09d32c Cr-Commit-Position: refs/heads/master@{#14031} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/c435946ec117d4f2180ef5cd3244ff48ef09d32c Cr-Commit-Position: refs/heads/master@{#14031} |