Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 2300813004: Moved the place for the aec_debug_dump build flag and changed the name to apm_debug_dump (Closed)

Created:
4 years, 3 months ago by peah-webrtc
Modified:
4 years, 3 months ago
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), kwiberg-webrtc, Andrew MacDonald, hlundin-webrtc, tterriberry_mozilla.com, audio-team_agora.io, qiang.lu, niklas.enbom, minyue-webrtc, the sun, aluebs-webrtc, bjornv1
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Moved the place for the aec_debug_dump build flag and changed the name to apm_debug_dump Currently, the aec_debug_dump buildflag can and is used to store data in the whole of the audio processing module. Therefore a more appropriate name is apm_debug_dump which also matches the names of the data dumping functionality. This CL makes that name change. The CL also changes the WEBRTC_AEC_DEBUG_DUMP define to WEBRTC_APM_DEBUG_DUMP == 1 Furthermore, this CL moves the buildflag to a more appropriate place. BUG=webrtc:5298 Committed: https://crrev.com/f28a3894465f5f78a61064f35bf7939da61ee225 Cr-Commit-Position: refs/heads/master@{#14026}

Patch Set 1 #

Patch Set 2 : Removed duplicate definition of build flag #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -46 lines) Patch
M webrtc/build/common.gypi View 1 chunk +4 lines, -0 lines 0 comments Download
M webrtc/build/webrtc.gni View 1 chunk +4 lines, -0 lines 0 comments Download
M webrtc/modules/audio_processing/BUILD.gn View 4 chunks +9 lines, -12 lines 0 comments Download
M webrtc/modules/audio_processing/audio_processing.gypi View 1 4 chunks +10 lines, -12 lines 0 comments Download
M webrtc/modules/audio_processing/logging/apm_data_dumper.h View 6 chunks +16 lines, -16 lines 0 comments Download
M webrtc/modules/audio_processing/logging/apm_data_dumper.cc View 3 chunks +6 lines, -6 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 17 (7 generated)
peah-webrtc
4 years, 3 months ago (2016-09-01 05:22:38 UTC) #3
kjellander_webrtc
lgtm assuming trybots are happy.
4 years, 3 months ago (2016-09-01 06:26:30 UTC) #4
peah-webrtc
On 2016/09/01 06:26:30, kjellander_webrtc wrote: > lgtm assuming trybots are happy. Sorry, but I found ...
4 years, 3 months ago (2016-09-01 09:24:22 UTC) #5
kjellander_webrtc
still lgtm
4 years, 3 months ago (2016-09-01 10:34:47 UTC) #6
hlundin-webrtc
lgtm
4 years, 3 months ago (2016-09-01 11:06:52 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2300813004/20001
4 years, 3 months ago (2016-09-01 11:16:12 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) win_clang_dbg on ...
4 years, 3 months ago (2016-09-01 13:16:37 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2300813004/20001
4 years, 3 months ago (2016-09-01 13:36:13 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-01 15:58:25 UTC) #15
commit-bot: I haz the power
4 years, 3 months ago (2016-09-01 15:58:37 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f28a3894465f5f78a61064f35bf7939da61ee225
Cr-Commit-Position: refs/heads/master@{#14026}

Powered by Google App Engine
This is Rietveld 408576698