Expose Ivf logging through the native API

webrtc/video/video_send_stream.h

Index: webrtc/video/video_send_stream.h
diff --git a/webrtc/video/video_send_stream.h b/webrtc/video/video_send_stream.h
index 932264265dddf75e3e762b6325141c0e4ae07957..78ffd845cee98c14d9cbba90151360af508f8793 100644
--- a/webrtc/video/video_send_stream.h
+++ b/webrtc/video/video_send_stream.h
@@ -76,6 +76,16 @@ class VideoSendStream : public webrtc::VideoSendStream {
   Stats GetStats() override;
 
   typedef std::map<uint32_t, RtpState> RtpStateMap;
+
+  // Takes ownership of each file, is responsible for closing them later.
+  // Calling this method will close and finalize any current logs.
+  // Giving rtc::kInvalidPlatformFileValue in any position disables logging
+  // for the corresponding stream.
+  void SetLogFiles(
+      rtc::PlatformFile file1 = rtc::kInvalidPlatformFileValue,
+      rtc::PlatformFile file2 = rtc::kInvalidPlatformFileValue,
+      rtc::PlatformFile file3 = rtc::kInvalidPlatformFileValue) override;
+

[sprang_webrtc, 2016/09/04 14:48:48]

Again, more descriptive name please.
Also need to comment on why there are multiple files.
Default values are unfortunately not allowed according to the style guide.
Maybe a vector of platform files could be used instead? If so comment on max
length (there is a "max simulcast streams" constant somewhere)

[palmkvist, 2016/09/05 11:57:37]

Does this seem reasonable?
// informative comments + streams with no corresponding file will not be logged
EnableEncodedFrameRecording(vector)
...and then in the actual interface put a helper
DisableEncodedFrameRecording()
that just calls the former method with a length 0 vector.

Threading two calls through the abstractions inbetween seems excessive, given
that one method necessarily has to support the behaviour of the other. At the
same time having an explicit Disable method makes things clearer, so I figure
this is a reasonable compromise.

[sprang_webrtc, 2016/09/05 12:23:53]

sgtm

   RtpStateMap StopPermanentlyAndGetRtpStates();
 
  private: