Expose Ivf logging through the native API

webrtc/video/video_send_stream.h

 /*
  *  Copyright (c) 2013 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 58 matching lines @@
   bool DeliverRtcp(const uint8_t* packet, size_t length);
 
   // webrtc::VideoSendStream implementation.
   void Start() override;
   void Stop() override;
   VideoCaptureInput* Input() override;
   void ReconfigureVideoEncoder(VideoEncoderConfig) override;
   Stats GetStats() override;
 
   typedef std::map<uint32_t, RtpState> RtpStateMap;
+
+  // Takes ownership of each file, is responsible for closing them later.
+  // Calling this method will close and finalize any current logs.
+  // Giving rtc::kInvalidPlatformFileValue in any position disables logging
+  // for the corresponding stream.
+  void SetLogFiles(
+      rtc::PlatformFile file1 = rtc::kInvalidPlatformFileValue,
+      rtc::PlatformFile file2 = rtc::kInvalidPlatformFileValue,
+      rtc::PlatformFile file3 = rtc::kInvalidPlatformFileValue) override;
+

[sprang_webrtc, 2016/09/04 14:48:48]

Again, more descriptive name please.
Also need to comment on why there are multiple files.
Default values are unfortunately not allowed according to the style guide.
Maybe a vector of platform files could be used instead? If so comment on max
length (there is a "max simulcast streams" constant somewhere)

[palmkvist, 2016/09/05 11:57:37]

Does this seem reasonable?
// informative comments + streams with no corresponding file will not be logged
EnableEncodedFrameRecording(vector)
...and then in the actual interface put a helper
DisableEncodedFrameRecording()
that just calls the former method with a length 0 vector.

Threading two calls through the abstractions inbetween seems excessive, given
that one method necessarily has to support the behaviour of the other. At the
same time having an explicit Disable method makes things clearer, so I figure
this is a reasonable compromise.

[sprang_webrtc, 2016/09/05 12:23:53]

sgtm

   RtpStateMap StopPermanentlyAndGetRtpStates();
 
  private:
   class ConstructionTask;
   class DestructAndGetRtpStateTask;
 
   rtc::ThreadChecker thread_checker_;
   rtc::TaskQueue* const worker_queue_;
   rtc::Event thread_sync_event_;
 
   SendStatisticsProxy stats_proxy_;
   const VideoSendStream::Config config_;
   std::unique_ptr<VideoSendStreamImpl> send_stream_;
   std::unique_ptr<ViEEncoder> vie_encoder_;
 };
 
 }  // namespace internal
 }  // namespace webrtc
 
 #endif  // WEBRTC_VIDEO_VIDEO_SEND_STREAM_H_