Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3091)

Unified Diff: webrtc/sdk/BUILD.gn

Issue 2300413002: GN Templates: Move common_config to the template. (Closed)
Patch Set: This might be it. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/sdk/BUILD.gn
diff --git a/webrtc/sdk/BUILD.gn b/webrtc/sdk/BUILD.gn
index 69ec091a790314c9f75ad73facf7f045b033bad3..657e3b9156d72b35719366befb8e30fe88905fc9 100644
--- a/webrtc/sdk/BUILD.gn
+++ b/webrtc/sdk/BUILD.gn
@@ -22,10 +22,7 @@ if (is_ios || (is_mac && mac_deployment_target == "10.7")) {
deps = [
"../base:rtc_base",
]
- configs += [
- "..:common_config",
- "//build/config/compiler:enable_arc",
- ]
+ configs += [ "//build/config/compiler:enable_arc" ]
public_configs = [
"..:common_inherited_config",
":rtc_sdk_common_objc_config",
@@ -189,6 +186,7 @@ if (is_ios || (is_mac && mac_deployment_target == "10.7")) {
"..:common_objc",
"//build/config/compiler:enable_arc",
]
+ suppressed_configs += [ rtc_common_config ]
kjellander_webrtc 2016/09/05 06:50:28 Same here, if needed, add a TODO (separate bug fro
public_configs = [ ":rtc_sdk_common_objc_config" ]

Powered by Google App Engine
This is Rietveld 408576698