GN Templates: Move common_config to the template.

webrtc/modules/video_coding/BUILD.gn

Index: webrtc/modules/video_coding/BUILD.gn
diff --git a/webrtc/modules/video_coding/BUILD.gn b/webrtc/modules/video_coding/BUILD.gn
index 8b40b7e02cca7e31843b18cd49566579740c967a..478533fc245e943b86f18968a858917122f3c74b 100644
--- a/webrtc/modules/video_coding/BUILD.gn
+++ b/webrtc/modules/video_coding/BUILD.gn
@@ -74,7 +74,6 @@ rtc_source_set("video_coding") {
     "video_sender.cc",
   ]
 
-  configs += [ "../..:common_config" ]
   public_configs = [ "../..:common_inherited_config" ]
 
   # TODO(jschuh): Bug 1348: fix this warning.
@@ -115,7 +114,6 @@ rtc_source_set("video_coding_utility") {
     "utility/vp8_header_parser.h",
   ]
 
-  configs += [ "../..:common_config" ]
   public_configs = [ "../..:common_inherited_config" ]
 
   if (is_clang) {
@@ -136,7 +134,6 @@ rtc_source_set("webrtc_h264") {
     "codecs/h264/include/h264.h",
   ]
 
-  configs += [ "../..:common_config" ]
   public_configs = [ "../..:common_inherited_config" ]
 
   if (is_clang) {
@@ -190,6 +187,8 @@ if (is_ios) {
       "//build/config/compiler:enable_arc",
     ]
 
+    suppressed_configs += [ rtc_common_config ]

[kjellander_webrtc, 2016/09/05 06:50:28]

Is this needed? Since it's not a part of examples/tests I would assume the GYP
version already had the common_config in the GYP build, so it really should pass
compilation.

Otherwise: add a TODO+bug for cleanup (and assign the bug to hbos@).

+
     deps = [
       "../../sdk:rtc_sdk_common_objc",
     ]
@@ -225,7 +224,6 @@ rtc_source_set("webrtc_i420") {
     "codecs/i420/include/i420.h",
   ]
 
-  configs += [ "../..:common_config" ]
   public_configs = [ "../..:common_inherited_config" ]
 
   if (is_clang) {
@@ -257,7 +255,6 @@ rtc_source_set("webrtc_vp8") {
     "codecs/vp8/vp8_impl.h",
   ]
 
-  configs += [ "../..:common_config" ]
   public_configs = [ "../..:common_inherited_config" ]
 
   # TODO(jschuh): Bug 1348: fix this warning.
@@ -291,7 +288,6 @@ rtc_source_set("webrtc_vp9") {
     "codecs/vp9/vp9_impl.h",
   ]
 
-  configs += [ "../..:common_config" ]
   public_configs = [ "../..:common_inherited_config" ]
 
   if (is_clang) {
@@ -325,7 +321,6 @@ if (rtc_include_tests) {
       "codecs/test/videoprocessor.h",
     ]
 
-    configs += [ "../..:common_config" ]
     public_configs = [ "../..:common_inherited_config" ]
 
     if (is_clang) {