Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1327)

Issue 2300003002: Enable send-side BWE by default. (Closed)

Created:
4 years, 3 months ago by stefan-webrtc
Modified:
4 years, 3 months ago
Reviewers:
mflodman
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, the sun
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Enable send-side BWE by default. BUG=webrtc:4173 R=mflodman@webrtc.org Committed: https://crrev.com/06a5e1aa3982177e875ddc10c82b1fa4f14393ce Cr-Commit-Position: refs/heads/master@{#14041}

Patch Set 1 #

Patch Set 2 : . #

Total comments: 2

Patch Set 3 : nit addressed. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -28 lines) Patch
M webrtc/media/engine/webrtcvideoengine2.cc View 1 chunk +3 lines, -5 lines 0 comments Download
M webrtc/media/engine/webrtcvideoengine2_unittest.cc View 1 2 chunks +3 lines, -18 lines 0 comments Download
M webrtc/sdk/objc/Framework/Classes/RTCFieldTrials.mm View 1 2 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 18 (11 generated)
stefan-webrtc
4 years, 3 months ago (2016-09-01 13:50:23 UTC) #4
mflodman
One comment, then LGTM. https://codereview.webrtc.org/2300003002/diff/20001/webrtc/sdk/objc/Framework/Classes/RTCFieldTrials.mm File webrtc/sdk/objc/Framework/Classes/RTCFieldTrials.mm (right): https://codereview.webrtc.org/2300003002/diff/20001/webrtc/sdk/objc/Framework/Classes/RTCFieldTrials.mm#newcode19 webrtc/sdk/objc/Framework/Classes/RTCFieldTrials.mm:19: static NSString * const kRTCEnableSendSideBweString ...
4 years, 3 months ago (2016-09-02 08:33:23 UTC) #7
stefan-webrtc
nit addressed.
4 years, 3 months ago (2016-09-02 08:39:41 UTC) #10
stefan-webrtc
https://codereview.webrtc.org/2300003002/diff/20001/webrtc/sdk/objc/Framework/Classes/RTCFieldTrials.mm File webrtc/sdk/objc/Framework/Classes/RTCFieldTrials.mm (right): https://codereview.webrtc.org/2300003002/diff/20001/webrtc/sdk/objc/Framework/Classes/RTCFieldTrials.mm#newcode19 webrtc/sdk/objc/Framework/Classes/RTCFieldTrials.mm:19: static NSString * const kRTCEnableSendSideBweString = On 2016/09/02 08:33:23, ...
4 years, 3 months ago (2016-09-02 08:39:58 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2300003002/40001
4 years, 3 months ago (2016-09-02 08:40:21 UTC) #14
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/06a5e1aa3982177e875ddc10c82b1fa4f14393ce Cr-Commit-Position: refs/heads/master@{#14041}
4 years, 3 months ago (2016-09-02 10:37:06 UTC) #17
stefan-webrtc
4 years, 3 months ago (2016-09-02 10:37:07 UTC) #18
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
06a5e1aa3982177e875ddc10c82b1fa4f14393ce (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698