Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Side by Side Diff: webrtc/sdk/objc/Framework/Classes/RTCFieldTrials.mm

Issue 2300003002: Enable send-side BWE by default. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: . Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/media/engine/webrtcvideoengine2_unittest.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2016 The WebRTC Project Authors. All rights reserved. 2 * Copyright 2016 The WebRTC Project Authors. All rights reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
11 #import "WebRTC/RTCFieldTrials.h" 11 #import "WebRTC/RTCFieldTrials.h"
12 12
13 #include <memory> 13 #include <memory>
14 14
15 #import "WebRTC/RTCLogging.h" 15 #import "WebRTC/RTCLogging.h"
16 16
17 #include "webrtc/system_wrappers/include/field_trial_default.h" 17 #include "webrtc/system_wrappers/include/field_trial_default.h"
18 18
19 static NSString * const kRTCEnableSendSideBweString = 19 static NSString * const kRTCEnableSendSideBweString =
mflodman 2016/09/02 08:33:23 Remove this too.
stefan-webrtc 2016/09/02 08:39:58 Done.
20 @"WebRTC-SendSideBwe/Enabled/"; 20 @"WebRTC-SendSideBwe/Enabled/";
21 static std::unique_ptr<char[]> gFieldTrialInitString; 21 static std::unique_ptr<char[]> gFieldTrialInitString;
22 22
23 void RTCInitFieldTrials(RTCFieldTrialOptions options) { 23 void RTCInitFieldTrials(RTCFieldTrialOptions options) {
24 NSMutableString *fieldTrialInitString = [NSMutableString string]; 24 NSMutableString *fieldTrialInitString = [NSMutableString string];
25 if (options & RTCFieldTrialOptionsSendSideBwe) {
26 [fieldTrialInitString appendString:kRTCEnableSendSideBweString];
27 }
28 size_t len = fieldTrialInitString.length + 1; 25 size_t len = fieldTrialInitString.length + 1;
29 gFieldTrialInitString.reset(new char[len]); 26 gFieldTrialInitString.reset(new char[len]);
30 if (![fieldTrialInitString getCString:gFieldTrialInitString.get() 27 if (![fieldTrialInitString getCString:gFieldTrialInitString.get()
31 maxLength:len 28 maxLength:len
32 encoding:NSUTF8StringEncoding]) { 29 encoding:NSUTF8StringEncoding]) {
33 RTCLogError(@"Failed to convert field trial string."); 30 RTCLogError(@"Failed to convert field trial string.");
34 return; 31 return;
35 } 32 }
36 webrtc::field_trial::InitFieldTrialsFromString(gFieldTrialInitString.get()); 33 webrtc::field_trial::InitFieldTrialsFromString(gFieldTrialInitString.get());
37 } 34 }
OLDNEW
« no previous file with comments | « webrtc/media/engine/webrtcvideoengine2_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698