Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 2299713002: Change a few configurations in AggressiveConfiguration (Closed)

Created:
4 years, 3 months ago by honghaiz3
Modified:
4 years, 3 months ago
Reviewers:
pthatcher1, skvlad
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Change a few configurations in AggressiveConfiguration Set bundle policy to max bundle. Set rtcp mux policy to required. Set enable ice renomination to true. This configuration is used by native applications. R=pthatcher@webrtc.org, skvlad@webrtc.org Committed: https://crrev.com/aecd982a6fddb0ebf81caefb08bb30f4b36a1841 Cr-Commit-Position: refs/heads/master@{#14057}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Merge and add receiving timeout to the Aggressive config #

Patch Set 3 : updating comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M webrtc/api/peerconnectioninterface.h View 1 2 2 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
honghaiz3
4 years, 3 months ago (2016-08-31 17:32:26 UTC) #2
pthatcher1
lgtm https://codereview.webrtc.org/2299713002/diff/1/webrtc/api/peerconnectioninterface.h File webrtc/api/peerconnectioninterface.h (right): https://codereview.webrtc.org/2299713002/diff/1/webrtc/api/peerconnectioninterface.h#newcode253 webrtc/api/peerconnectioninterface.h:253: config.enable_ice_renomination = true; Continual gathering? Low receiving timeout?
4 years, 3 months ago (2016-08-31 17:55:28 UTC) #3
skvlad
lgtm
4 years, 3 months ago (2016-08-31 20:21:48 UTC) #5
honghaiz3
https://codereview.webrtc.org/2299713002/diff/1/webrtc/api/peerconnectioninterface.h File webrtc/api/peerconnectioninterface.h (right): https://codereview.webrtc.org/2299713002/diff/1/webrtc/api/peerconnectioninterface.h#newcode253 webrtc/api/peerconnectioninterface.h:253: config.enable_ice_renomination = true; On 2016/08/31 17:55:28, pthatcher1 wrote: > ...
4 years, 3 months ago (2016-09-02 16:20:32 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2299713002/40001
4 years, 3 months ago (2016-09-02 23:27:05 UTC) #9
honghaiz3
Committed patchset #3 (id:40001) manually as aecd982a6fddb0ebf81caefb08bb30f4b36a1841 (presubmit successful).
4 years, 3 months ago (2016-09-02 23:58:32 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-09-02 23:58:33 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/aecd982a6fddb0ebf81caefb08bb30f4b36a1841
Cr-Commit-Position: refs/heads/master@{#14057}

Powered by Google App Engine
This is Rietveld 408576698