Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Side by Side Diff: webrtc/api/peerconnectioninterface.h

Issue 2299713002: Change a few configurations in AggressiveConfiguration (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2012 The WebRTC project authors. All Rights Reserved. 2 * Copyright 2012 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 230 matching lines...) Expand 10 before | Expand all | Expand 10 after
241 // Chrome in particular. 241 // Chrome in particular.
242 242
243 // A configuration that is safer to use, despite it may not have the best 243 // A configuration that is safer to use, despite it may not have the best
244 // performance. 244 // performance.
245 static RTCConfiguration SafeConfiguration() { return RTCConfiguration(); } 245 static RTCConfiguration SafeConfiguration() { return RTCConfiguration(); }
246 246
247 // An aggressive configuration that has better performance, although it 247 // An aggressive configuration that has better performance, although it
248 // may be riskier and may need extra support in the application. 248 // may be riskier and may need extra support in the application.
249 static RTCConfiguration AggressiveConfiguration() { 249 static RTCConfiguration AggressiveConfiguration() {
250 RTCConfiguration config; 250 RTCConfiguration config;
251 config.bundle_policy = kBundlePolicyMaxBundle;
252 config.rtcp_mux_policy = kRtcpMuxPolicyRequire;
253 config.enable_ice_renomination = true;
pthatcher1 2016/08/31 17:55:28 Continual gathering? Low receiving timeout?
honghaiz3 2016/09/02 16:20:32 I add low receiving timeout but not continual gath
251 config.redetermine_role_on_ice_restart = false; 254 config.redetermine_role_on_ice_restart = false;
252 return config; 255 return config;
253 } 256 }
254 257
255 bool dscp() { return media_config.enable_dscp; } 258 bool dscp() { return media_config.enable_dscp; }
256 void set_dscp(bool enable) { media_config.enable_dscp = enable; } 259 void set_dscp(bool enable) { media_config.enable_dscp = enable; }
257 260
258 // TODO(nisse): The corresponding flag in MediaConfig and 261 // TODO(nisse): The corresponding flag in MediaConfig and
259 // elsewhere should be renamed enable_cpu_adaptation. 262 // elsewhere should be renamed enable_cpu_adaptation.
260 bool cpu_adaptation() { 263 bool cpu_adaptation() {
(...skipping 491 matching lines...) Expand 10 before | Expand all | Expand 10 after
752 cricket::WebRtcVideoEncoderFactory* encoder_factory, 755 cricket::WebRtcVideoEncoderFactory* encoder_factory,
753 cricket::WebRtcVideoDecoderFactory* decoder_factory) { 756 cricket::WebRtcVideoDecoderFactory* decoder_factory) {
754 return CreatePeerConnectionFactory( 757 return CreatePeerConnectionFactory(
755 worker_and_network_thread, worker_and_network_thread, signaling_thread, 758 worker_and_network_thread, worker_and_network_thread, signaling_thread,
756 default_adm, encoder_factory, decoder_factory); 759 default_adm, encoder_factory, decoder_factory);
757 } 760 }
758 761
759 } // namespace webrtc 762 } // namespace webrtc
760 763
761 #endif // WEBRTC_API_PEERCONNECTIONINTERFACE_H_ 764 #endif // WEBRTC_API_PEERCONNECTIONINTERFACE_H_
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698