Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(500)

Issue 2298063003: Reland of move the old AndroidVideoCapturer stack code. (Closed)

Created:
4 years, 3 months ago by sakal
Modified:
4 years, 3 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland of move the old AndroidVideoCapturer stack code. (patchset #1 id:1 of https://codereview.webrtc.org/2291583002/ ) Reason for revert: Downstream apps should now be fixed. Original issue's description: > Revert of Remove the old AndroidVideoCapturer stack code. (patchset #2 id:20001 of https://codereview.webrtc.org/2235893003/ ) > > Reason for revert: > Breaks downstream. > > Original issue's description: > > Remove the old AndroidVideoCapturer stack code. > > > > This code is no longer needed. Apps should be using the new API introduced here: https://codereview.webrtc.org/2127893002/ > > > > Committed: https://crrev.com/1b365a8db070f9cdcbf35ec871f758dcd909e51d > > Cr-Commit-Position: refs/heads/master@{#13950} > > TBR=magjed@webrtc.org,glaznev@webrtc.org,kjellander@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > > Committed: https://crrev.com/e39f251dacf66e50153bcda615f06b7c59e5856b > Cr-Commit-Position: refs/heads/master@{#13958} TBR=magjed@webrtc.org,glaznev@webrtc.org,kjellander@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. Committed: https://crrev.com/9e4a3040ed602bb6517a97ae53b4308bcb3d4be0 Cr-Commit-Position: refs/heads/master@{#13988}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -725 lines) Patch
M webrtc/api/BUILD.gn View 2 chunks +0 lines, -4 lines 0 comments Download
M webrtc/api/android/java/src/org/webrtc/PeerConnectionFactory.java View 2 chunks +1 line, -16 lines 0 comments Download
M webrtc/api/android/java/src/org/webrtc/VideoCapturer.java View 1 chunk +0 lines, -47 lines 0 comments Download
D webrtc/api/android/jni/androidvideocapturer_jni.h View 1 chunk +0 lines, -101 lines 0 comments Download
D webrtc/api/android/jni/androidvideocapturer_jni.cc View 1 chunk +0 lines, -349 lines 0 comments Download
M webrtc/api/android/jni/classreferenceholder.cc View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/api/android/jni/peerconnection_jni.cc View 3 chunks +1 line, -26 lines 0 comments Download
D webrtc/api/androidvideocapturer.h View 1 chunk +0 lines, -84 lines 0 comments Download
D webrtc/api/androidvideocapturer.cc View 1 chunk +0 lines, -93 lines 0 comments Download
M webrtc/api/api.gyp View 2 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
sakal
Created Reland of move the old AndroidVideoCapturer stack code.
4 years, 3 months ago (2016-08-31 07:57:54 UTC) #1
sakal
PTAL
4 years, 3 months ago (2016-08-31 07:58:20 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2298063003/1
4 years, 3 months ago (2016-08-31 07:58:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2298063003/1
4 years, 3 months ago (2016-08-31 08:08:21 UTC) #7
magjed_webrtc
lgtm
4 years, 3 months ago (2016-08-31 09:35:14 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-31 09:53:53 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-08-31 09:54:02 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9e4a3040ed602bb6517a97ae53b4308bcb3d4be0
Cr-Commit-Position: refs/heads/master@{#13988}

Powered by Google App Engine
This is Rietveld 408576698