AndroidVideoTrackSource implementation

This implementation greatly simplifies Android video capturing stack. The old
stack will be removed soon in a separate CL. Constraints will not be supported
in the new implementation. Apps can request a format directly and the closest
supported format will be selected.

Changes needed from the apps:
1. Use the new createVideoSource without constraints.
2. Call startCapture manually.
3. Don't call videoSource.stop/restart, use startCapture/stopCapture instead.

R=magjed@webrtc.org
TBR=kjellander@webrtc.org

Committed: https://crrev.com/16032126eda1d723492248859e40c26cdb1e93ee
Cr-Commit-Position: refs/heads/master@{#13504}

[sakal, 2016-07-18 14:10:56]

Description was changed from

==========
WIP VideoCapturer stack refactor

R=magjed@webrtc.org
==========

to

==========
This implementation greatly simplifies Android video capturing stack. The old
stack will be removed soon in a separate CL. Constraints will not be supported
in the new implementation. Apps request a format directly and closest one
supported is selected.

Changes needed from the apps:
1. Use the new createVideoSource without constraints
2. Call startCapture manually
3. Don't call videoSource.stop/restart, use startCapture/stopCapture instead.

R=magjed@webrtc.org
==========

[sakal, 2016-07-18 14:14:30]

Description was changed from

==========
This implementation greatly simplifies Android video capturing stack. The old
stack will be removed soon in a separate CL. Constraints will not be supported
in the new implementation. Apps request a format directly and closest one
supported is selected.

Changes needed from the apps:
1. Use the new createVideoSource without constraints
2. Call startCapture manually
3. Don't call videoSource.stop/restart, use startCapture/stopCapture instead.

R=magjed@webrtc.org
==========

to

==========
This implementation greatly simplifies Android video capturing stack. The old
stack will be removed soon in a separate CL. Constraints will not be supported
in the new implementation. Apps can request a format directly and closest one
supported is selected.

Changes needed from the apps:
1. Use the new createVideoSource without constraints.
2. Call startCapture manually.
3. Don't call videoSource.stop/restart, use startCapture/stopCapture instead.

R=magjed@webrtc.org
==========

[sakal, 2016-07-18 14:15:27]

Magnus, PTAL.

[magjed_webrtc, 2016-07-19 09:23:11]

Description was changed from

==========
This implementation greatly simplifies Android video capturing stack. The old
stack will be removed soon in a separate CL. Constraints will not be supported
in the new implementation. Apps can request a format directly and closest one
supported is selected.

Changes needed from the apps:
1. Use the new createVideoSource without constraints.
2. Call startCapture manually.
3. Don't call videoSource.stop/restart, use startCapture/stopCapture instead.

R=magjed@webrtc.org
==========

to

==========
This implementation greatly simplifies Android video capturing stack. The old
stack will be removed soon in a separate CL. Constraints will not be supported
in the new implementation. Apps can request a format directly and the closest
supported format will be selected.

Changes needed from the apps:
1. Use the new createVideoSource without constraints.
2. Call startCapture manually.
3. Don't call videoSource.stop/restart, use startCapture/stopCapture instead.

R=magjed@webrtc.org
==========

[magjed_webrtc, 2016-07-19 12:57:47]

https://codereview.webrtc.org/2127893002/diff/100001/webrtc/api/android/java/...
File webrtc/api/android/java/src/org/webrtc/PeerConnectionFactory.java (right):

https://codereview.webrtc.org/2127893002/diff/100001/webrtc/api/android/java/...
webrtc/api/android/java/src/org/webrtc/PeerConnectionFactory.java:116: public
VideoSource createVideoSource(
Comment that this function is deprecated. Also comment that it starts the
capturer. Also, please replace "capturer.release()" with "capturer.dispose()" in
the existing comment.

https://codereview.webrtc.org/2127893002/diff/100001/webrtc/api/android/java/...
webrtc/api/android/java/src/org/webrtc/PeerConnectionFactory.java:125:
VideoCapturer capturer) {
nit: This argument fits on the previous line.

https://codereview.webrtc.org/2127893002/diff/100001/webrtc/api/android/java/...
File webrtc/api/android/java/src/org/webrtc/VideoCapturer.java (right):

https://codereview.webrtc.org/2127893002/diff/100001/webrtc/api/android/java/...
webrtc/api/android/java/src/org/webrtc/VideoCapturer.java:92: // Pointer to
AndroidVideoTrackSource
super nit: dot at end of sentence.

https://codereview.webrtc.org/2127893002/diff/100001/webrtc/api/android/jni/a...
File webrtc/api/android/jni/androidvideotracksource_jni.cc (right):

https://codereview.webrtc.org/2127893002/diff/100001/webrtc/api/android/jni/a...
webrtc/api/android/jni/androidvideotracksource_jni.cc:28: auto proxy_source =
Add a static helper method in this file for converting the jlong to
AndroidVideoTrackSource*.

https://codereview.webrtc.org/2127893002/diff/100001/webrtc/api/android/jni/a...
webrtc/api/android/jni/androidvideotracksource_jni.cc:33: jbyte* bytes =
jni->GetByteArrayElements(j_frame, &is_copy);
Remove is_copy and pass nullptr instead.

https://codereview.webrtc.org/2127893002/diff/100001/webrtc/api/androidvideot...
File webrtc/api/androidvideotracksource.cc (right):

https://codereview.webrtc.org/2127893002/diff/100001/webrtc/api/androidvideot...
webrtc/api/androidvideotracksource.cc:29: LOG(LS_INFO) <<
"AndroidVideoTrackSource dtor";
I don't think this log is necessary, so you can remove the dtor and rely on the
default one.

https://codereview.webrtc.org/2127893002/diff/100001/webrtc/api/androidvideot...
webrtc/api/androidvideotracksource.cc:75: const rtc::VideoSinkWants& wants) {
Only called on worker thread?

https://codereview.webrtc.org/2127893002/diff/100001/webrtc/api/androidvideot...
webrtc/api/androidvideotracksource.cc:135: // RTC_CHECK_EQ(uv_plane + uv_width *
height - y_plane, length);
Add this check:
RTC_CHECK_GE(length, width * height + 2 * uv_width * ((height + 1) / 2));
or remove comment.

https://codereview.webrtc.org/2127893002/diff/100001/webrtc/api/androidvideot...
webrtc/api/androidvideotracksource.cc:230: int64_t system_time_us,
Remove system_time_us as argument and add 'int64_t system_time_us =
rtc::TimeMicros();' in function body instead.

https://codereview.webrtc.org/2127893002/diff/100001/webrtc/api/androidvideot...
webrtc/api/androidvideotracksource.cc:241: translated_camera_time_us
This if-statement is not necessary, we always pass a pointer.

https://codereview.webrtc.org/2127893002/diff/100001/webrtc/api/androidvideot...
webrtc/api/androidvideotracksource.cc:258: if (translated_camera_time_us) {
This if-statement is not necessary, we always pass a pointer.

https://codereview.webrtc.org/2127893002/diff/100001/webrtc/api/androidvideot...
webrtc/api/androidvideotracksource.cc:264: }
empty line between }:s and comment "// namespace webrtc".

https://codereview.webrtc.org/2127893002/diff/100001/webrtc/api/androidvideot...
File webrtc/api/androidvideotracksource.h (right):

https://codereview.webrtc.org/2127893002/diff/100001/webrtc/api/androidvideot...
webrtc/api/androidvideotracksource.h:70: void OnFrame(const cricket::VideoFrame&
frame, int width, int height);
Make private.

https://codereview.webrtc.org/2127893002/diff/100001/webrtc/api/androidvideot...
webrtc/api/androidvideotracksource.h:95: rtc::CriticalSection stats_crit_;
Move this to the line above stats_.

https://codereview.webrtc.org/2127893002/diff/100001/webrtc/api/androidvideot...
webrtc/api/androidvideotracksource.h:122: }
nit: Add empty line between }:s and comment "// namespace webrtc" on the last.

https://codereview.webrtc.org/2127893002/diff/100001/webrtc/examples/androida...
File webrtc/examples/androidapp/src/org/appspot/apprtc/PeerConnectionClient.java
(right):

https://codereview.webrtc.org/2127893002/diff/100001/webrtc/examples/androida...
webrtc/examples/androidapp/src/org/appspot/apprtc/PeerConnectionClient.java:408:
// If video resolution is not specified, force it to HD.
I think you should change the comment to something like: "If video resolution is
not specified, default to HD." We don't really force anything.

https://codereview.webrtc.org/2127893002/diff/100001/webrtc/examples/androida...
webrtc/examples/androidapp/src/org/appspot/apprtc/PeerConnectionClient.java:414:
// If fps is not specified, force it to 30.
ditto: update comment.

https://codereview.webrtc.org/2127893002/diff/100001/webrtc/examples/androida...
webrtc/examples/androidapp/src/org/appspot/apprtc/PeerConnectionClient.java:579:
videoCapturer.stopCapture();
Maybe we shouldn't throw InterruptedException now when stopCapture() is called
manually from apps, but we can fix that in another CL.

[sakal, 2016-07-19 13:46:23]

https://codereview.webrtc.org/2127893002/diff/100001/webrtc/api/android/java/...
File webrtc/api/android/java/src/org/webrtc/PeerConnectionFactory.java (right):

https://codereview.webrtc.org/2127893002/diff/100001/webrtc/api/android/java/...
webrtc/api/android/java/src/org/webrtc/PeerConnectionFactory.java:116: public
VideoSource createVideoSource(
On 2016/07/19 12:57:46, magjed_webrtc wrote:
> Comment that this function is deprecated. Also comment that it starts the
> capturer. Also, please replace "capturer.release()" with "capturer.dispose()"
in
> the existing comment.

Done.

https://codereview.webrtc.org/2127893002/diff/100001/webrtc/api/android/java/...
webrtc/api/android/java/src/org/webrtc/PeerConnectionFactory.java:125:
VideoCapturer capturer) {
On 2016/07/19 12:57:46, magjed_webrtc wrote:
> nit: This argument fits on the previous line.

Done.

https://codereview.webrtc.org/2127893002/diff/100001/webrtc/api/android/java/...
File webrtc/api/android/java/src/org/webrtc/VideoCapturer.java (right):

https://codereview.webrtc.org/2127893002/diff/100001/webrtc/api/android/java/...
webrtc/api/android/java/src/org/webrtc/VideoCapturer.java:92: // Pointer to
AndroidVideoTrackSource
On 2016/07/19 12:57:46, magjed_webrtc wrote:
> super nit: dot at end of sentence.

Done, this comment was actually outdated, fixed.

https://codereview.webrtc.org/2127893002/diff/100001/webrtc/api/android/jni/a...
File webrtc/api/android/jni/androidvideotracksource_jni.cc (right):

https://codereview.webrtc.org/2127893002/diff/100001/webrtc/api/android/jni/a...
webrtc/api/android/jni/androidvideotracksource_jni.cc:28: auto proxy_source =
On 2016/07/19 12:57:46, magjed_webrtc wrote:
> Add a static helper method in this file for converting the jlong to
> AndroidVideoTrackSource*.

Done.

https://codereview.webrtc.org/2127893002/diff/100001/webrtc/api/android/jni/a...
webrtc/api/android/jni/androidvideotracksource_jni.cc:33: jbyte* bytes =
jni->GetByteArrayElements(j_frame, &is_copy);
On 2016/07/19 12:57:46, magjed_webrtc wrote:
> Remove is_copy and pass nullptr instead.

Done.

https://codereview.webrtc.org/2127893002/diff/100001/webrtc/api/androidvideot...
File webrtc/api/androidvideotracksource.cc (right):

https://codereview.webrtc.org/2127893002/diff/100001/webrtc/api/androidvideot...
webrtc/api/androidvideotracksource.cc:29: LOG(LS_INFO) <<
"AndroidVideoTrackSource dtor";
On 2016/07/19 12:57:47, magjed_webrtc wrote:
> I don't think this log is necessary, so you can remove the dtor and rely on
the
> default one.

Done.

https://codereview.webrtc.org/2127893002/diff/100001/webrtc/api/androidvideot...
webrtc/api/androidvideotracksource.cc:75: const rtc::VideoSinkWants& wants) {
On 2016/07/19 12:57:47, magjed_webrtc wrote:
> Only called on worker thread?

Added a lock.

https://codereview.webrtc.org/2127893002/diff/100001/webrtc/api/androidvideot...
webrtc/api/androidvideotracksource.cc:135: // RTC_CHECK_EQ(uv_plane + uv_width *
height - y_plane, length);
On 2016/07/19 12:57:47, magjed_webrtc wrote:
> Add this check:
> RTC_CHECK_GE(length, width * height + 2 * uv_width * ((height + 1) / 2));
> or remove comment.

Done.

https://codereview.webrtc.org/2127893002/diff/100001/webrtc/api/androidvideot...
webrtc/api/androidvideotracksource.cc:230: int64_t system_time_us,
On 2016/07/19 12:57:47, magjed_webrtc wrote:
> Remove system_time_us as argument and add 'int64_t system_time_us =
> rtc::TimeMicros();' in function body instead.

Done.

https://codereview.webrtc.org/2127893002/diff/100001/webrtc/api/androidvideot...
webrtc/api/androidvideotracksource.cc:241: translated_camera_time_us
On 2016/07/19 12:57:47, magjed_webrtc wrote:
> This if-statement is not necessary, we always pass a pointer.

Done.

https://codereview.webrtc.org/2127893002/diff/100001/webrtc/api/androidvideot...
webrtc/api/androidvideotracksource.cc:258: if (translated_camera_time_us) {
On 2016/07/19 12:57:47, magjed_webrtc wrote:
> This if-statement is not necessary, we always pass a pointer.

Done.

https://codereview.webrtc.org/2127893002/diff/100001/webrtc/api/androidvideot...
webrtc/api/androidvideotracksource.cc:264: }
On 2016/07/19 12:57:47, magjed_webrtc wrote:
> empty line between }:s and comment "// namespace webrtc".

Done.

https://codereview.webrtc.org/2127893002/diff/100001/webrtc/api/androidvideot...
File webrtc/api/androidvideotracksource.h (right):

https://codereview.webrtc.org/2127893002/diff/100001/webrtc/api/androidvideot...
webrtc/api/androidvideotracksource.h:70: void OnFrame(const cricket::VideoFrame&
frame, int width, int height);
On 2016/07/19 12:57:47, magjed_webrtc wrote:
> Make private.

Done.

https://codereview.webrtc.org/2127893002/diff/100001/webrtc/api/androidvideot...
webrtc/api/androidvideotracksource.h:95: rtc::CriticalSection stats_crit_;
On 2016/07/19 12:57:47, magjed_webrtc wrote:
> Move this to the line above stats_.

Done.

https://codereview.webrtc.org/2127893002/diff/100001/webrtc/api/androidvideot...
webrtc/api/androidvideotracksource.h:122: }
On 2016/07/19 12:57:47, magjed_webrtc wrote:
> nit: Add empty line between }:s and comment "// namespace webrtc" on the last.

Done.

https://codereview.webrtc.org/2127893002/diff/100001/webrtc/examples/androida...
File webrtc/examples/androidapp/src/org/appspot/apprtc/PeerConnectionClient.java
(right):

https://codereview.webrtc.org/2127893002/diff/100001/webrtc/examples/androida...
webrtc/examples/androidapp/src/org/appspot/apprtc/PeerConnectionClient.java:408:
// If video resolution is not specified, force it to HD.
On 2016/07/19 12:57:47, magjed_webrtc wrote:
> I think you should change the comment to something like: "If video resolution
is
> not specified, default to HD." We don't really force anything.

Done.

https://codereview.webrtc.org/2127893002/diff/100001/webrtc/examples/androida...
webrtc/examples/androidapp/src/org/appspot/apprtc/PeerConnectionClient.java:414:
// If fps is not specified, force it to 30.
On 2016/07/19 12:57:47, magjed_webrtc wrote:
> ditto: update comment.

Done.

https://codereview.webrtc.org/2127893002/diff/100001/webrtc/examples/androida...
webrtc/examples/androidapp/src/org/appspot/apprtc/PeerConnectionClient.java:579:
videoCapturer.stopCapture();
On 2016/07/19 12:57:47, magjed_webrtc wrote:
> Maybe we shouldn't throw InterruptedException now when stopCapture() is called
> manually from apps, but we can fix that in another CL.

Agree, will handle this in a separate CL.

[magjed_webrtc, 2016-07-19 14:42:29]

lgtm

https://codereview.webrtc.org/2127893002/diff/120001/webrtc/api/android/jni/a...
File webrtc/api/android/jni/androidvideotracksource_jni.cc (right):

https://codereview.webrtc.org/2127893002/diff/120001/webrtc/api/android/jni/a...
webrtc/api/android/jni/androidvideotracksource_jni.cc:35: auto source =
AndroidVideoTrackSourceFromJavaProxy(j_source);
I prefer 'webrtc::AndroidVideoTrackSource*' over auto here.

https://codereview.webrtc.org/2127893002/diff/120001/webrtc/api/androidvideot...
File webrtc/api/androidvideotracksource.cc (right):

https://codereview.webrtc.org/2127893002/diff/120001/webrtc/api/androidvideot...
webrtc/api/androidvideotracksource.cc:74: apply_rotation_ =
wants.rotation_applied;
Just lock this statement, and not video_adapter_.OnResolutionRequest.

https://codereview.webrtc.org/2127893002/diff/120001/webrtc/api/androidvideot...
webrtc/api/androidvideotracksource.cc:87: rtc::CritScope
lock(&apply_rotation_crit_);
Move it as close as possible to the first use of |apply_rotation_|.

https://codereview.webrtc.org/2127893002/diff/120001/webrtc/api/androidvideot...
webrtc/api/androidvideotracksource.cc:235: RTC_CHECK(translated_camera_time_us
!= nullptr);
No need for this, it will crash regardless.

https://codereview.webrtc.org/2127893002/diff/120001/webrtc/api/androidvideot...
webrtc/api/androidvideotracksource.cc:240:
timestamp_aligner_.UpdateOffset(camera_time_us, system_time_us);
I don't understand why we have to make two calls to TimestampAligner and pass in
the return value from the first call to the second call. But it's completely
unrelated to your CL.

[sakal, 2016-07-20 08:04:34]

The CQ bit was checked by sakal@webrtc.org

[sakal, 2016-07-20 08:04:34]

The patchset sent to the CQ was uploaded after l-g-t-m from magjed@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2127893002/#ps140001 (title:
"Changes according to magjed's comments #2")

[commit-bot: I haz the power, 2016-07-20 08:04:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[sakal, 2016-07-20 08:06:28]

https://codereview.webrtc.org/2127893002/diff/120001/webrtc/api/android/jni/a...
File webrtc/api/android/jni/androidvideotracksource_jni.cc (right):

https://codereview.webrtc.org/2127893002/diff/120001/webrtc/api/android/jni/a...
webrtc/api/android/jni/androidvideotracksource_jni.cc:35: auto source =
AndroidVideoTrackSourceFromJavaProxy(j_source);
On 2016/07/19 14:42:28, magjed_webrtc wrote:
> I prefer 'webrtc::AndroidVideoTrackSource*' over auto here.

Done.

https://codereview.webrtc.org/2127893002/diff/120001/webrtc/api/androidvideot...
File webrtc/api/androidvideotracksource.cc (right):

https://codereview.webrtc.org/2127893002/diff/120001/webrtc/api/androidvideot...
webrtc/api/androidvideotracksource.cc:74: apply_rotation_ =
wants.rotation_applied;
On 2016/07/19 14:42:28, magjed_webrtc wrote:
> Just lock this statement, and not video_adapter_.OnResolutionRequest.

Done.

https://codereview.webrtc.org/2127893002/diff/120001/webrtc/api/androidvideot...
webrtc/api/androidvideotracksource.cc:87: rtc::CritScope
lock(&apply_rotation_crit_);
On 2016/07/19 14:42:28, magjed_webrtc wrote:
> Move it as close as possible to the first use of |apply_rotation_|.

Done.

https://codereview.webrtc.org/2127893002/diff/120001/webrtc/api/androidvideot...
webrtc/api/androidvideotracksource.cc:235: RTC_CHECK(translated_camera_time_us
!= nullptr);
On 2016/07/19 14:42:28, magjed_webrtc wrote:
> No need for this, it will crash regardless.

I think crashing is undefined behavior but sure it will crash on any sane
system.

https://codereview.webrtc.org/2127893002/diff/120001/webrtc/api/androidvideot...
webrtc/api/androidvideotracksource.cc:240:
timestamp_aligner_.UpdateOffset(camera_time_us, system_time_us);
On 2016/07/19 14:42:28, magjed_webrtc wrote:
> I don't understand why we have to make two calls to TimestampAligner and pass
in
> the return value from the first call to the second call. But it's completely
> unrelated to your CL.

Acknowledged.

[magjed_webrtc, 2016-07-20 08:08:29]

https://codereview.webrtc.org/2127893002/diff/140001/webrtc/api/android/java/...
File webrtc/api/android/java/src/org/webrtc/VideoCapturer.java (right):

https://codereview.webrtc.org/2127893002/diff/140001/webrtc/api/android/java/...
webrtc/api/android/java/src/org/webrtc/VideoCapturer.java:24: void
onCapturerStopped();
We should probably add onCapturerStarting() as well in order to set the state
SourceState::kInitializing. Or fold these state callbacks in a single
onStateChanged(State);

[commit-bot: I haz the power, 2016-07-20 08:18:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-20 08:18:27]

Try jobs failed on following builders:
  presubmit on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/6903)

[sakal, 2016-07-20 08:38:16]

Description was changed from

==========
This implementation greatly simplifies Android video capturing stack. The old
stack will be removed soon in a separate CL. Constraints will not be supported
in the new implementation. Apps can request a format directly and the closest
supported format will be selected.

Changes needed from the apps:
1. Use the new createVideoSource without constraints.
2. Call startCapture manually.
3. Don't call videoSource.stop/restart, use startCapture/stopCapture instead.

R=magjed@webrtc.org
==========

to

==========
This implementation greatly simplifies Android video capturing stack. The old
stack will be removed soon in a separate CL. Constraints will not be supported
in the new implementation. Apps can request a format directly and the closest
supported format will be selected.

Changes needed from the apps:
1. Use the new createVideoSource without constraints.
2. Call startCapture manually.
3. Don't call videoSource.stop/restart, use startCapture/stopCapture instead.

R=magjed@webrtc.org
TBR=kjellander@webrtc.org
==========

[sakal, 2016-07-20 08:38:16]

sakal@webrtc.org changed reviewers:
+ kjellander@webrtc.org

[sakal, 2016-07-20 08:38:40]

TBR kjellander for the BUILD.gn file.

[sakal, 2016-07-20 08:39:03]

The CQ bit was checked by sakal@webrtc.org

[sakal, 2016-07-20 08:39:03]

The patchset sent to the CQ was uploaded after l-g-t-m from magjed@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2127893002/#ps160001 (title:
"Add OWNERs for files.")

[commit-bot: I haz the power, 2016-07-20 08:39:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-07-20 08:48:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-20 08:48:38]

Try jobs failed on following builders:
  ios64_gn_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios64_gn_rel/builds/1247)

[sakal, 2016-07-20 09:15:41]

The CQ bit was checked by sakal@webrtc.org

[sakal, 2016-07-20 09:15:42]

The patchset sent to the CQ was uploaded after l-g-t-m from magjed@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2127893002/#ps180001 (title:
"Fix cpplint errors.")

[commit-bot: I haz the power, 2016-07-20 09:15:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-07-20 10:04:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-20 10:04:10]

Try jobs failed on following builders:
  android_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_rel/builds/14931)

[sakal, 2016-07-20 14:13:30]

Description was changed from

==========
This implementation greatly simplifies Android video capturing stack. The old
stack will be removed soon in a separate CL. Constraints will not be supported
in the new implementation. Apps can request a format directly and the closest
supported format will be selected.

Changes needed from the apps:
1. Use the new createVideoSource without constraints.
2. Call startCapture manually.
3. Don't call videoSource.stop/restart, use startCapture/stopCapture instead.

R=magjed@webrtc.org
TBR=kjellander@webrtc.org
==========

to

==========
This implementation greatly simplifies Android video capturing stack. The old
stack will be removed soon in a separate CL. Constraints will not be supported
in the new implementation. Apps can request a format directly and the closest
supported format will be selected.

Changes needed from the apps:
1. Use the new createVideoSource without constraints.
2. Call startCapture manually.
3. Don't call videoSource.stop/restart, use startCapture/stopCapture instead.

R=magjed@webrtc.org
TBR=kjellander@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/16032126eda1d723492248859...
==========

[sakal, 2016-07-20 14:13:31]

Committed patchset #10 (id:180001) manually as
16032126eda1d723492248859e40c26cdb1e93ee (presubmit successful).

[commit-bot: I haz the power, 2016-07-20 14:56:44]

Description was changed from

==========
This implementation greatly simplifies Android video capturing stack. The old
stack will be removed soon in a separate CL. Constraints will not be supported
in the new implementation. Apps can request a format directly and the closest
supported format will be selected.

Changes needed from the apps:
1. Use the new createVideoSource without constraints.
2. Call startCapture manually.
3. Don't call videoSource.stop/restart, use startCapture/stopCapture instead.

R=magjed@webrtc.org
TBR=kjellander@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/16032126eda1d723492248859...
==========

to

==========
This implementation greatly simplifies Android video capturing stack. The old
stack will be removed soon in a separate CL. Constraints will not be supported
in the new implementation. Apps can request a format directly and the closest
supported format will be selected.

Changes needed from the apps:
1. Use the new createVideoSource without constraints.
2. Call startCapture manually.
3. Don't call videoSource.stop/restart, use startCapture/stopCapture instead.

R=magjed@webrtc.org
TBR=kjellander@webrtc.org

Committed: https://crrev.com/16032126eda1d723492248859e40c26cdb1e93ee
Cr-Commit-Position: refs/heads/master@{#13504}
==========

[kjellander_webrtc, 2016-07-24 08:12:22]

lgtm