Issue 2296953003: Remove faulty DCHECK in rtcp::TransportFeedback DecodeSymbol

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2296953003: Remove faulty DCHECK in rtcp::TransportFeedback DecodeSymbol (Closed)

Created:
4 years, 3 months ago by danilchap

Modified:
4 years, 3 months ago

Reviewers:
sprang_webrtc

CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, stefan-webrtc, mflodman

Base URL:
https://chromium.googlesource.com/external/webrtc.git@master

Target Ref:
refs/pending/heads/master

Project:
webrtc

Visibility:
Public.

Remove faulty DCHECK in rtcp::TransportFeedback DecodeSymbol BUG=chromium:642745 R=sprang@webrtc.org Committed: https://crrev.com/20fcbf15f063d43acc3ad3d4c5134b92644dc13f Cr-Commit-Position: refs/heads/master@{#14003}

Created: 4 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	webrtc/modules/rtp_rtcp/source/rtcp_packet/transport_feedback.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Total messages: 5 (2 generated)

danilchap

4 years, 3 months ago (2016-08-31 16:47:38 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
20fcbf15f063d43acc3ad3d4c5134b92644dc13f (presubmit successful).