Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(533)

Unified Diff: webrtc/modules/rtp_rtcp/source/rtcp_packet/transport_feedback.cc

Issue 2296953003: Remove faulty DCHECK in rtcp::TransportFeedback DecodeSymbol (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/modules/rtp_rtcp/source/rtcp_packet/transport_feedback.cc
diff --git a/webrtc/modules/rtp_rtcp/source/rtcp_packet/transport_feedback.cc b/webrtc/modules/rtp_rtcp/source/rtcp_packet/transport_feedback.cc
index cce0075adef1cb8d56308861f7f0327896ed4676..a4f0f6bbdc56a50a25da45e955b9a1bde5cf589a 100644
--- a/webrtc/modules/rtp_rtcp/source/rtcp_packet/transport_feedback.cc
+++ b/webrtc/modules/rtp_rtcp/source/rtcp_packet/transport_feedback.cc
@@ -60,7 +60,11 @@ TransportFeedback::StatusSymbol DecodeSymbol(uint8_t value) {
return TransportFeedback::StatusSymbol::kReceivedSmallDelta;
case 2:
return TransportFeedback::StatusSymbol::kReceivedLargeDelta;
+ case 3:
+ // It is invalid, but |value| comes from network, so can be any.
+ return TransportFeedback::StatusSymbol::kNotReceived;
default:
+ // Caller should pass 2 bits max.
RTC_NOTREACHED();
return TransportFeedback::StatusSymbol::kNotReceived;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698