Plot accumelated packets over time.

Plot accumelated packets over time.

BUG=

Committed: https://crrev.com/ccd74896615700ab3ada9c024a726b3491f23300
Cr-Commit-Position: refs/heads/master@{#14066}

[philipel, 2016-09-02 11:30:14]

philipel@webrtc.org changed reviewers:
+ stefan@webrtc.org, terelius@webrtc.org

[stefan-webrtc, 2016-09-02 12:12:17]

https://codereview.webrtc.org/2295063006/diff/1/webrtc/tools/event_log_visual...
File webrtc/tools/event_log_visualizer/analyzer.cc (right):

https://codereview.webrtc.org/2295063006/diff/1/webrtc/tools/event_log_visual...
webrtc/tools/event_log_visualizer/analyzer.cc:504: // RTP packet
RTP packets.

https://codereview.webrtc.org/2295063006/diff/1/webrtc/tools/event_log_visual...
webrtc/tools/event_log_visualizer/analyzer.cc:526: }
Can you break this out into a separate function and reuse it for both RTP and
RTCP packets?

https://codereview.webrtc.org/2295063006/diff/1/webrtc/tools/event_log_visual...
webrtc/tools/event_log_visualizer/analyzer.cc:528: // RTCP packet
RTCP packets.

https://codereview.webrtc.org/2295063006/diff/1/webrtc/tools/event_log_visual...
webrtc/tools/event_log_visualizer/analyzer.cc:555: plot->SetTitle("Accumelated
Incoming RTP/RTCP packets");
"Accumulated" here and below.

https://codereview.webrtc.org/2295063006/diff/1/webrtc/tools/event_log_visual...
File webrtc/tools/event_log_visualizer/analyzer.h (right):

https://codereview.webrtc.org/2295063006/diff/1/webrtc/tools/event_log_visual...
webrtc/tools/event_log_visualizer/analyzer.h:63: void
CreateAccumelatedPacketsGraph(PacketDirection desired_direction,
Accumulated

[philipel, 2016-09-02 13:15:25]

https://codereview.webrtc.org/2295063006/diff/1/webrtc/tools/event_log_visual...
File webrtc/tools/event_log_visualizer/analyzer.cc (right):

https://codereview.webrtc.org/2295063006/diff/1/webrtc/tools/event_log_visual...
webrtc/tools/event_log_visualizer/analyzer.cc:504: // RTP packet
On 2016/09/02 12:12:17, stefan-webrtc (holmer) wrote:
> RTP packets.

Done.

https://codereview.webrtc.org/2295063006/diff/1/webrtc/tools/event_log_visual...
webrtc/tools/event_log_visualizer/analyzer.cc:526: }
On 2016/09/02 12:12:17, stefan-webrtc (holmer) wrote:
> Can you break this out into a separate function and reuse it for both RTP and
> RTCP packets?

Done.

https://codereview.webrtc.org/2295063006/diff/1/webrtc/tools/event_log_visual...
webrtc/tools/event_log_visualizer/analyzer.cc:528: // RTCP packet
On 2016/09/02 12:12:16, stefan-webrtc (holmer) wrote:
> RTCP packets.

Done.

https://codereview.webrtc.org/2295063006/diff/1/webrtc/tools/event_log_visual...
webrtc/tools/event_log_visualizer/analyzer.cc:555: plot->SetTitle("Accumelated
Incoming RTP/RTCP packets");
On 2016/09/02 12:12:16, stefan-webrtc (holmer) wrote:
> "Accumulated" here and below.

Done.

https://codereview.webrtc.org/2295063006/diff/1/webrtc/tools/event_log_visual...
File webrtc/tools/event_log_visualizer/analyzer.h (right):

https://codereview.webrtc.org/2295063006/diff/1/webrtc/tools/event_log_visual...
webrtc/tools/event_log_visualizer/analyzer.h:63: void
CreateAccumelatedPacketsGraph(PacketDirection desired_direction,
On 2016/09/02 12:12:17, stefan-webrtc (holmer) wrote:
> Accumulated

Done.

[stefan-webrtc, 2016-09-02 15:27:23]

lgtm % nit

https://codereview.webrtc.org/2295063006/diff/20001/webrtc/tools/event_log_vi...
File webrtc/tools/event_log_visualizer/analyzer.cc (right):

https://codereview.webrtc.org/2295063006/diff/20001/webrtc/tools/event_log_vi...
webrtc/tools/event_log_visualizer/analyzer.cc:505: const std::map<StreamId,
std::vector<T>>& data,
Call this packets instead

[philipel, 2016-09-05 09:02:17]

The CQ bit was checked by philipel@webrtc.org

[philipel, 2016-09-05 09:02:18]

The patchset sent to the CQ was uploaded after l-g-t-m from stefan@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2295063006/#ps40001 (title:
"data --> packets")

[commit-bot: I haz the power, 2016-09-05 09:02:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-09-05 09:46:28]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-05 09:46:35]

Description was changed from

==========
Plot accumelated packets over time.

BUG=
==========

to

==========
Plot accumelated packets over time.

BUG=

Committed: https://crrev.com/ccd74896615700ab3ada9c024a726b3491f23300
Cr-Commit-Position: refs/heads/master@{#14066}
==========

[commit-bot: I haz the power, 2016-09-05 09:46:36]

Patchset 3 (id:??) landed as
https://crrev.com/ccd74896615700ab3ada9c024a726b3491f23300
Cr-Commit-Position: refs/heads/master@{#14066}