Plot accumelated packets over time.

webrtc/tools/event_log_visualizer/analyzer.cc

 /*
  *  Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 480 matching lines @@
   plot->SetXAxis(0, call_duration_s_, "Time (s)", kLeftMargin, kRightMargin);
   plot->SetSuggestedYAxis(0, 1, "Packet size (bytes)", kBottomMargin,
                           kTopMargin);
   if (desired_direction == webrtc::PacketDirection::kIncomingPacket) {
     plot->SetTitle("Incoming RTP packets");
   } else if (desired_direction == webrtc::PacketDirection::kOutgoingPacket) {
     plot->SetTitle("Outgoing RTP packets");
   }
 }
 
+void EventLogAnalyzer::CreateAccumelatedPacketsGraph(
+    PacketDirection desired_direction,
+    Plot* plot) {
+  // RTP packet

[stefan-webrtc, 2016/09/02 12:12:17]

RTP packets.

[philipel, 2016/09/02 13:15:25]

Done.

+  for (auto& kv : rtp_packets_) {
+    StreamId stream_id = kv.first;
+    const std::vector<LoggedRtpPacket>& packet_stream = kv.second;
+    // Filter on direction and SSRC.
+    if (stream_id.GetDirection() != desired_direction ||
+        !MatchingSsrc(stream_id.GetSsrc(), desired_ssrc_)) {
+      continue;
+    }
+
+    TimeSeries time_series;
+    time_series.label = "RTP: " + SsrcToString(stream_id.GetSsrc());
+    time_series.style = LINE_GRAPH;
+
+    for (size_t i = 0; i < packet_stream.size(); i++) {
+      float x = static_cast<float>(packet_stream[i].timestamp - begin_time_) /
+                1000000;
+      time_series.points.emplace_back(x, i);
+      time_series.points.emplace_back(x, i + 1);
+    }
+
+    plot->series_list_.push_back(std::move(time_series));
+  }

[stefan-webrtc, 2016/09/02 12:12:17]

Can you break this out into a separate function and reuse it for both RTP and
RTCP packets?

[philipel, 2016/09/02 13:15:25]

Done.

+
+  // RTCP packet

[stefan-webrtc, 2016/09/02 12:12:16]

RTCP packets.

[philipel, 2016/09/02 13:15:25]

Done.

+  for (auto& kv : rtcp_packets_) {
+    StreamId stream_id = kv.first;
+    const std::vector<LoggedRtcpPacket>& packet_stream = kv.second;
+    // Filter on direction and SSRC.
+    if (stream_id.GetDirection() != desired_direction ||
+        !MatchingSsrc(stream_id.GetSsrc(), desired_ssrc_)) {
+      continue;
+    }
+
+    TimeSeries time_series;
+    time_series.label = "RTCP: " + SsrcToString(stream_id.GetSsrc());
+    time_series.style = LINE_GRAPH;
+
+    for (size_t i = 0; i < packet_stream.size(); i++) {
+      float x = static_cast<float>(packet_stream[i].timestamp - begin_time_) /
+                1000000;
+      time_series.points.emplace_back(x, i);
+      time_series.points.emplace_back(x, i + 1);
+    }
+
+    plot->series_list_.push_back(std::move(time_series));
+  }
+
+  plot->SetXAxis(0, call_duration_s_, "Time (s)", kLeftMargin, kRightMargin);
+  plot->SetSuggestedYAxis(0, 1, "Received Packets", kBottomMargin, kTopMargin);
+  if (desired_direction == webrtc::PacketDirection::kIncomingPacket) {
+    plot->SetTitle("Accumelated Incoming RTP/RTCP packets");

[stefan-webrtc, 2016/09/02 12:12:16]

"Accumulated" here and below.

[philipel, 2016/09/02 13:15:25]

Done.

+  } else if (desired_direction == webrtc::PacketDirection::kOutgoingPacket) {
+    plot->SetTitle("Accumelated Outgoing RTP/RTCP packets");
+  }
+}
+
 // For each SSRC, plot the time between the consecutive playouts.
 void EventLogAnalyzer::CreatePlayoutGraph(Plot* plot) {
   std::map<uint32_t, TimeSeries> time_series;
   std::map<uint32_t, uint64_t> last_playout;
 
   uint32_t ssrc;
 
   for (size_t i = 0; i < parsed_log_.GetNumberOfEvents(); i++) {
     ParsedRtcEventLog::EventType event_type = parsed_log_.GetEventType(i);
     if (event_type == ParsedRtcEventLog::AUDIO_PLAYOUT_EVENT) {
@@ skipping 431 matching lines @@
     point.y -= estimated_base_delay_ms;
   // Add the data set to the plot.
   plot->series_list_.push_back(std::move(time_series));
 
   plot->SetXAxis(0, call_duration_s_, "Time (s)", kLeftMargin, kRightMargin);
   plot->SetSuggestedYAxis(0, 10, "Delay (ms)", kBottomMargin, kTopMargin);
   plot->SetTitle("Network Delay Change.");
 }
 }  // namespace plotting
 }  // namespace webrtc