Fix off-by-one error in DCHECK in ProducerFec.

Fix off-by-one error in DCHECK in ProducerFec.

BUG=chromium:642743
Committed: https://crrev.com/624c33578f41dc6d4d0415bd91572e461c59014b
Cr-Commit-Position: refs/heads/master@{#14018}

[brandtr, 2016-09-01 07:31:58]

brandtr@webrtc.org changed reviewers:
+ danilchap@webrtc.org

[brandtr, 2016-09-01 07:31:58]

Please take a look at this small fix :)

The bug was introduced here:
https://codereview.webrtc.org/2110763002/diff/340001/webrtc/modules/rtp_rtcp/...

I checked that CL for other issues, but couldn't find any.

[danilchap, 2016-09-01 07:59:18]

lgtm % nit

https://codereview.webrtc.org/2294243005/diff/1/webrtc/modules/rtp_rtcp/sourc...
File webrtc/modules/rtp_rtcp/source/producer_fec_unittest.cc (right):

https://codereview.webrtc.org/2294243005/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/producer_fec_unittest.cc:190: constexpr size_t
kFrameId = 0;
may be constexpr int kOffset = 0;
NextPacket name this parameter offset and use it as a random generator.
Doesn't feel related to Frame Id and definitely not a size_t.

Or, like in previous test do not introduce this constant since it is completely
irrelevant for this test.

https://codereview.webrtc.org/2294243005/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/producer_fec_unittest.cc:199:
EXPECT_EQ(packet->length + 1, red_packet->length());
this + 1 is + kRedForFecHeaderLength?

[brandtr, 2016-09-01 09:29:18]

https://codereview.webrtc.org/2294243005/diff/1/webrtc/modules/rtp_rtcp/sourc...
File webrtc/modules/rtp_rtcp/source/producer_fec_unittest.cc (right):

https://codereview.webrtc.org/2294243005/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/producer_fec_unittest.cc:190: constexpr size_t
kFrameId = 0;
On 2016/09/01 07:59:17, danilchap wrote:
> may be constexpr int kOffset = 0;
> NextPacket name this parameter offset and use it as a random generator.
> Doesn't feel related to Frame Id and definitely not a size_t.
> 
> Or, like in previous test do not introduce this constant since it is
completely
> irrelevant for this test.

I'm not a fan of unnamed literals in the tests, but I still changed to that here
to avoid the confusion about what this offset means. The offset affects the
payload of the generated packets, and is typically used to separate the payloads
of different frames. Not really applicable here though.

About the type, I'd argue that it should be size_t in the signature of
NextPacket :)

https://codereview.webrtc.org/2294243005/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/producer_fec_unittest.cc:199:
EXPECT_EQ(packet->length + 1, red_packet->length());
On 2016/09/01 07:59:17, danilchap wrote:
> this + 1 is + kRedForFecHeaderLength?

Yes, clarified.

[brandtr, 2016-09-01 11:53:49]

The CQ bit was checked by brandtr@webrtc.org

[brandtr, 2016-09-01 11:53:50]

The patchset sent to the CQ was uploaded after l-g-t-m from danilchap@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2294243005/#ps20001 (title:
"Response to feedback.")

[commit-bot: I haz the power, 2016-09-01 11:53:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-09-01 12:01:58]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-01 12:02:08]

Description was changed from

==========
Fix off-by-one error in DCHECK in ProducerFec.

BUG=chromium:642743
==========

to

==========
Fix off-by-one error in DCHECK in ProducerFec.

BUG=chromium:642743

Committed: https://crrev.com/624c33578f41dc6d4d0415bd91572e461c59014b
Cr-Commit-Position: refs/heads/master@{#14018}
==========

[commit-bot: I haz the power, 2016-09-01 12:02:09]

Patchset 2 (id:??) landed as
https://crrev.com/624c33578f41dc6d4d0415bd91572e461c59014b
Cr-Commit-Position: refs/heads/master@{#14018}