Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Unified Diff: webrtc/modules/rtp_rtcp/source/producer_fec_unittest.cc

Issue 2294243005: Fix off-by-one error in DCHECK in ProducerFec. (Closed)
Patch Set: Response to feedback. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/modules/rtp_rtcp/source/producer_fec.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/modules/rtp_rtcp/source/producer_fec_unittest.cc
diff --git a/webrtc/modules/rtp_rtcp/source/producer_fec_unittest.cc b/webrtc/modules/rtp_rtcp/source/producer_fec_unittest.cc
index 8b84cf5712229c19df61b50dee55271f649f4961..e3a49b43cc3869ed68ccba0b3410da356a2b36c8 100644
--- a/webrtc/modules/rtp_rtcp/source/producer_fec_unittest.cc
+++ b/webrtc/modules/rtp_rtcp/source/producer_fec_unittest.cc
@@ -185,4 +185,22 @@ TEST_F(ProducerFecTest, BuildRedPacket) {
delete packet;
}
+TEST_F(ProducerFecTest, BuildRedPacketWithEmptyPayload) {
+ constexpr size_t kNumFrames = 1;
+ constexpr size_t kPayloadLength = 0;
+ constexpr size_t kRedForFecHeaderLength = 1;
+
+ generator_.NewFrame(kNumFrames);
+ std::unique_ptr<test::RawRtpPacket> packet(
+ generator_.NextPacket(0, kPayloadLength));
+ std::unique_ptr<RedPacket> red_packet =
+ ProducerFec::BuildRedPacket(packet->data, packet->length - kRtpHeaderSize,
+ kRtpHeaderSize, kRedPayloadType);
+ EXPECT_EQ(packet->length + kRedForFecHeaderLength, red_packet->length());
+ VerifyHeader(packet->header.header.sequenceNumber,
+ packet->header.header.timestamp, kRedPayloadType,
+ packet->header.header.payloadType, red_packet.get(),
+ true); // Marker bit set.
+}
+
} // namespace webrtc
« no previous file with comments | « webrtc/modules/rtp_rtcp/source/producer_fec.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698