Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Issue 2291583002: Revert of Remove the old AndroidVideoCapturer stack code. (Closed)

Created:
4 years, 3 months ago by sakal
Modified:
4 years, 3 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Remove the old AndroidVideoCapturer stack code. (patchset #2 id:20001 of https://codereview.webrtc.org/2235893003/ ) Reason for revert: Breaks downstream. Original issue's description: > Remove the old AndroidVideoCapturer stack code. > > This code is no longer needed. Apps should be using the new API introduced here: https://codereview.webrtc.org/2127893002/ > > Committed: https://crrev.com/1b365a8db070f9cdcbf35ec871f758dcd909e51d > Cr-Commit-Position: refs/heads/master@{#13950} TBR=magjed@webrtc.org,glaznev@webrtc.org,kjellander@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/e39f251dacf66e50153bcda615f06b7c59e5856b Cr-Commit-Position: refs/heads/master@{#13958}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+725 lines, -2 lines) Patch
M webrtc/api/BUILD.gn View 2 chunks +4 lines, -0 lines 0 comments Download
M webrtc/api/android/java/src/org/webrtc/PeerConnectionFactory.java View 2 chunks +16 lines, -1 line 0 comments Download
M webrtc/api/android/java/src/org/webrtc/VideoCapturer.java View 1 chunk +47 lines, -0 lines 0 comments Download
A webrtc/api/android/jni/androidvideocapturer_jni.h View 1 chunk +101 lines, -0 lines 0 comments Download
A webrtc/api/android/jni/androidvideocapturer_jni.cc View 1 chunk +349 lines, -0 lines 0 comments Download
M webrtc/api/android/jni/classreferenceholder.cc View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/api/android/jni/peerconnection_jni.cc View 3 chunks +26 lines, -1 line 0 comments Download
A webrtc/api/androidvideocapturer.h View 1 chunk +84 lines, -0 lines 0 comments Download
A webrtc/api/androidvideocapturer.cc View 1 chunk +93 lines, -0 lines 0 comments Download
M webrtc/api/api.gyp View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
sakal
Created Revert of Remove the old AndroidVideoCapturer stack code.
4 years, 3 months ago (2016-08-29 14:31:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2291583002/1
4 years, 3 months ago (2016-08-29 14:31:20 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-29 14:31:28 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/e39f251dacf66e50153bcda615f06b7c59e5856b Cr-Commit-Position: refs/heads/master@{#13958}
4 years, 3 months ago (2016-08-29 14:31:34 UTC) #6
sakal
4 years, 3 months ago (2016-08-31 07:57:53 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2298063003/ by sakal@webrtc.org.

The reason for reverting is: Downstream apps should now be fixed..

Powered by Google App Engine
This is Rietveld 408576698