Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2290173002: NetEq: Add a few EXPECT_CALLs to PacketBuffer unittests (Closed)

Created:
4 years, 3 months ago by hlundin-webrtc
Modified:
4 years, 3 months ago
Reviewers:
ivoc
CC:
webrtc-reviews_webrtc.org, kwiberg-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

NetEq: Add a few EXPECT_CALLs to PacketBuffer unittests This will silence a few noisy print-outs. Committed: https://crrev.com/ebd9fd7918c5979dee0c6be85d8bcf23c485d742 Cr-Commit-Position: refs/heads/master@{#14005}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -0 lines) Patch
M webrtc/modules/audio_coding/neteq/packet_buffer_unittest.cc View 5 chunks +25 lines, -0 lines 0 comments Download

Depends on Patchset:

Issue 2290153002 Patch 1

Messages

Total messages: 12 (5 generated)
hlundin-webrtc
Ivo, PTAL. Thanks!
4 years, 3 months ago (2016-08-30 09:50:02 UTC) #2
ivoc
LGTM.
4 years, 3 months ago (2016-08-30 15:02:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2290173002/1
4 years, 3 months ago (2016-08-31 10:46:38 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: ios64_gn_dbg on master.tryserver.webrtc (JOB_FAILED, no build URL) ios64_gn_rel on ...
4 years, 3 months ago (2016-08-31 10:47:48 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2290173002/1
4 years, 3 months ago (2016-08-31 17:46:25 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-31 20:03:39 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-08-31 20:03:46 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/ebd9fd7918c5979dee0c6be85d8bcf23c485d742
Cr-Commit-Position: refs/heads/master@{#14005}

Powered by Google App Engine
This is Rietveld 408576698