NetEq: Change member variables for current RTP types to rtc::Optionals

NetEq: Change member variables for current RTP types to rtc::Optionals

With this change, the value 0xFF is no longer used to flag that the RTP
type is unknown. Instead, an empty value for the rtc::Optional is used.

Committed: https://crrev.com/da8bbf6e3c96adce367e9e2bcdbc4d3a0bc4bdaa
Cr-Commit-Position: refs/heads/master@{#13989}

[hlundin-webrtc, 2016-08-30 08:55:48]

henrik.lundin@webrtc.org changed reviewers:
+ kwiberg@webrtc.org

[hlundin-webrtc, 2016-08-30 08:55:49]

kwiberg, PTAL.

[kwiberg-webrtc, 2016-08-30 10:29:33]

https://codereview.webrtc.org/2290153002/diff/1/webrtc/modules/audio_coding/n...
File webrtc/modules/audio_coding/neteq/neteq_impl.cc (right):

https://codereview.webrtc.org/2290153002/diff/1/webrtc/modules/audio_coding/n...
webrtc/modules/audio_coding/neteq/neteq_impl.cc:747: << " is unknown where it
shouldn't be";
If !current_rtp_payload_type_, you evaluate *current_rtp_payload_type_ when
producing the error message. Maybe

  if (current_rtp_payload_type_) {
    RTC_DCHECK(decoder_database_
        ->GetDecoderInfo(*current_rtp_payload_type_))
        << "Payload type "
        << static_cast<int>(*current_rtp_payload_type_)
        << " is unknown where it shouldn't be";
  }

https://codereview.webrtc.org/2290153002/diff/1/webrtc/modules/audio_coding/n...
File webrtc/modules/audio_coding/neteq/packet_buffer_unittest.cc (right):

https://codereview.webrtc.org/2290153002/diff/1/webrtc/modules/audio_coding/n...
webrtc/modules/audio_coding/neteq/packet_buffer_unittest.cc:185: EXPECT_EQ(0,
current_pt.value_or(-1));  // Current payload type changed to 0.
Or

  EXPECT_EQ(rtc::Optional<uint8_t>(0), current_pt);

[hlundin-webrtc, 2016-08-30 10:53:16]

Thanks! PTAL again.

https://codereview.webrtc.org/2290153002/diff/1/webrtc/modules/audio_coding/n...
File webrtc/modules/audio_coding/neteq/neteq_impl.cc (right):

https://codereview.webrtc.org/2290153002/diff/1/webrtc/modules/audio_coding/n...
webrtc/modules/audio_coding/neteq/neteq_impl.cc:747: << " is unknown where it
shouldn't be";
On 2016/08/30 10:29:32, kwiberg-webrtc wrote:
> If !current_rtp_payload_type_, you evaluate *current_rtp_payload_type_ when
> producing the error message. Maybe
> 
>   if (current_rtp_payload_type_) {
>     RTC_DCHECK(decoder_database_
>         ->GetDecoderInfo(*current_rtp_payload_type_))
>         << "Payload type "
>         << static_cast<int>(*current_rtp_payload_type_)
>         << " is unknown where it shouldn't be";
>   }

Oh, that's not good. Changed. Done.

https://codereview.webrtc.org/2290153002/diff/1/webrtc/modules/audio_coding/n...
File webrtc/modules/audio_coding/neteq/packet_buffer_unittest.cc (right):

https://codereview.webrtc.org/2290153002/diff/1/webrtc/modules/audio_coding/n...
webrtc/modules/audio_coding/neteq/packet_buffer_unittest.cc:185: EXPECT_EQ(0,
current_pt.value_or(-1));  // Current payload type changed to 0.
On 2016/08/30 10:29:32, kwiberg-webrtc wrote:
> Or
> 
>   EXPECT_EQ(rtc::Optional<uint8_t>(0), current_pt);

Done.

[kwiberg-webrtc, 2016-08-30 11:51:26]

lgtm

[hlundin-webrtc, 2016-08-30 11:58:47]

The CQ bit was checked by henrik.lundin@webrtc.org

[commit-bot: I haz the power, 2016-08-30 11:58:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-08-30 13:59:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-30 13:59:48]

Try jobs failed on following builders:
  android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  android_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  win_clang_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[hlundin-webrtc, 2016-08-31 09:04:51]

The CQ bit was checked by henrik.lundin@webrtc.org

[commit-bot: I haz the power, 2016-08-31 09:04:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-08-31 10:14:14]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-31 10:14:21]

Description was changed from

==========
NetEq: Change member variables for current RTP types to rtc::Optionals

With this change, the value 0xFF is no longer used to flag that the RTP
type is unknown. Instead, an empty value for the rtc::Optional is used.
==========

to

==========
NetEq: Change member variables for current RTP types to rtc::Optionals

With this change, the value 0xFF is no longer used to flag that the RTP
type is unknown. Instead, an empty value for the rtc::Optional is used.

Committed: https://crrev.com/da8bbf6e3c96adce367e9e2bcdbc4d3a0bc4bdaa
Cr-Commit-Position: refs/heads/master@{#13989}
==========

[commit-bot: I haz the power, 2016-08-31 10:14:23]

Patchset 2 (id:??) landed as
https://crrev.com/da8bbf6e3c96adce367e9e2bcdbc4d3a0bc4bdaa
Cr-Commit-Position: refs/heads/master@{#13989}