Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 2287243002: Add NetEq::FilteredCurrentDelayMs() and use it in VoiceEngine (Closed)

Created:
4 years, 3 months ago by hlundin-webrtc
Modified:
4 years, 3 months ago
Reviewers:
CC:
webrtc-reviews_webrtc.org
Target Ref:
refs/pending/branch-heads/53
Project:
webrtc
Visibility:
Public.

Description

Add NetEq::FilteredCurrentDelayMs() and use it in VoiceEngine The new method returns the current total delay (packet buffer and sync buffer) in ms, with smoothing applied to even out short-time fluctuations due to jitter. The packet buffer part of the delay is not updated during DTX/CNG periods. This CL also pipes the new metric through ACM and uses it in VoiceEngine. It replaces the previous method of estimating the buffer delay (where an inserted packet's RTP timestamp was compared with the last played timestamp from NetEq). The new method works better under periods of DTX/CNG. Review-Url: https://codereview.webrtc.org/2262203002 Cr-Commit-Position: refs/heads/master@{#13855} (cherry picked from commit b3f1c5d2fe00ac2201e533345f55eee220d66876) BUG=chromium:640913 TBR=tina.legrand@webrtc.org NOPRESUBMIT=true NOTRY=true

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -5 lines) Patch
M webrtc/modules/audio_coding/acm2/acm_receiver.h View 1 chunk +7 lines, -0 lines 0 comments Download
M webrtc/modules/audio_coding/acm2/acm_receiver.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M webrtc/modules/audio_coding/acm2/audio_coding_module.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M webrtc/modules/audio_coding/include/audio_coding_module.h View 1 chunk +9 lines, -0 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/include/neteq.h View 1 chunk +5 lines, -0 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/neteq_impl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/neteq_impl.cc View 1 chunk +16 lines, -0 lines 0 comments Download
M webrtc/voice_engine/channel.cc View 2 chunks +4 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2287243002/1
4 years, 3 months ago (2016-08-29 07:47:09 UTC) #4
commit-bot: I haz the power
CLs for remote refs other than refs/pending/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
4 years, 3 months ago (2016-08-29 07:47:11 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2287243002/1
4 years, 3 months ago (2016-08-29 07:47:58 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-08-29 07:48:13 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698