Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issue 2262203002: Add NetEq::FilteredCurrentDelayMs() and use it in VoiceEngine (Closed)

Created:
4 years, 4 months ago by hlundin-webrtc
Modified:
4 years, 4 months ago
CC:
webrtc-reviews_webrtc.org, kwiberg-webrtc, Andrew MacDonald, henrika_webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc, the sun
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add NetEq::FilteredCurrentDelayMs() and use it in VoiceEngine The new method returns the current total delay (packet buffer and sync buffer) in ms, with smoothing applied to even out short-time fluctuations due to jitter. The packet buffer part of the delay is not updated during DTX/CNG periods. This CL also pipes the new metric through ACM and uses it in VoiceEngine. It replaces the previous method of estimating the buffer delay (where an inserted packet's RTP timestamp was compared with the last played timestamp from NetEq). The new method works better under periods of DTX/CNG. Committed: https://crrev.com/b3f1c5d2fe00ac2201e533345f55eee220d66876 Cr-Commit-Position: refs/heads/master@{#13855}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -5 lines) Patch
M webrtc/modules/audio_coding/acm2/acm_receiver.h View 1 chunk +7 lines, -0 lines 0 comments Download
M webrtc/modules/audio_coding/acm2/acm_receiver.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M webrtc/modules/audio_coding/acm2/audio_coding_module.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M webrtc/modules/audio_coding/include/audio_coding_module.h View 1 chunk +9 lines, -0 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/include/neteq.h View 1 chunk +5 lines, -0 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/neteq_impl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/neteq_impl.cc View 1 chunk +16 lines, -0 lines 0 comments Download
M webrtc/voice_engine/channel.cc View 2 chunks +4 lines, -5 lines 1 comment Download

Messages

Total messages: 10 (4 generated)
hlundin-webrtc
Tina, PTAL.
4 years, 4 months ago (2016-08-22 15:27:18 UTC) #2
tlegrand-webrtc
On 2016/08/22 15:27:18, hlundin-webrtc wrote: > Tina, PTAL. Nice! LGTM
4 years, 4 months ago (2016-08-22 18:57:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2262203002/1
4 years, 4 months ago (2016-08-22 21:18:11 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-22 22:39:56 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/b3f1c5d2fe00ac2201e533345f55eee220d66876 Cr-Commit-Position: refs/heads/master@{#13855}
4 years, 4 months ago (2016-08-22 22:40:06 UTC) #8
the sun
4 years, 4 months ago (2016-08-23 06:45:07 UTC) #10
Message was sent while issue was closed.
https://codereview.webrtc.org/2262203002/diff/1/webrtc/voice_engine/channel.cc
File webrtc/voice_engine/channel.cc (right):

https://codereview.webrtc.org/2262203002/diff/1/webrtc/voice_engine/channel.c...
webrtc/voice_engine/channel.cc:3391: // be deleted, along with a few member
variables. (WebRTC issue 6237.)
Oh, that would be so nice!

Powered by Google App Engine
This is Rietveld 408576698