webrtc/modules/video_coding/codecs/h264/h264_encoder_impl.cc - Issue 2286633002: Delete IsZeroSize method.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/video_coding/codecs/h264/h264_encoder_impl.cc

Issue 2286633002: Delete IsZeroSize method. (Closed)

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/modules/video_coding/codecs/h264/h264_encoder_impl.cc

diff --git a/webrtc/modules/video_coding/codecs/h264/h264_encoder_impl.cc b/webrtc/modules/video_coding/codecs/h264/h264_encoder_impl.cc

index bba30a3ca81acc368b9a13365f54ed06b1c94cd1..c9c719d917a42c8765ad08fbbe964bc3e55d46f3 100644

--- a/webrtc/modules/video_coding/codecs/h264/h264_encoder_impl.cc

+++ b/webrtc/modules/video_coding/codecs/h264/h264_encoder_impl.cc

@@ -277,10 +277,6 @@ int32_t H264EncoderImpl::Encode(const VideoFrame& input_frame,

ReportError();

return WEBRTC_VIDEO_CODEC_UNINITIALIZED;

}

- if (input_frame.IsZeroSize()) {

stefan-webrtc 2016/09/05 14:45:25 Should we DCHECK that we have a video_frame_buffer

- ReportError();

- return WEBRTC_VIDEO_CODEC_ERR_PARAMETER;

- }

if (!encoded_image_callback_) {

LOG(LS_WARNING) << "InitEncode() has been called, but a callback function "

<< "has not been set with RegisterEncodeCompleteCallback()";