webrtc/modules/video_coding/codecs/h264/h264_video_toolbox_encoder.mm - Issue 2286633002: Delete IsZeroSize method.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/video_coding/codecs/h264/h264_video_toolbox_encoder.mm

Issue 2286633002: Delete IsZeroSize method. (Closed)

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« webrtc/modules/video_coding/codecs/h264/h264_encoder_impl.cc ('K') | « webrtc/modules/video_coding/codecs/h264/h264_encoder_impl.cc ('k') | webrtc/modules/video_coding/codecs/vp8/simulcast_encoder_adapter.cc » ('j') | webrtc/video/video_quality_test.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/video_coding/codecs/h264/h264_video_toolbox_encoder.mm

diff --git a/webrtc/modules/video_coding/codecs/h264/h264_video_toolbox_encoder.mm b/webrtc/modules/video_coding/codecs/h264/h264_video_toolbox_encoder.mm

index 2d1e2a1416d350e02da3db3a17f7ec00a085c206..83c774acd4d0cf1e3682bd8f80189f2ad2a0fd3a 100644

--- a/webrtc/modules/video_coding/codecs/h264/h264_video_toolbox_encoder.mm

+++ b/webrtc/modules/video_coding/codecs/h264/h264_video_toolbox_encoder.mm

@@ -256,7 +256,6 @@ int H264VideoToolboxEncoder::Encode(

const VideoFrame& frame,

const CodecSpecificInfo* codec_specific_info,

const std::vector<FrameType>* frame_types) {

- RTC_DCHECK(!frame.IsZeroSize());

stefan-webrtc 2016/09/05 14:45:25 Could you comment on why this isn't necessary?

if (!callback_ || !compression_session_) {

return WEBRTC_VIDEO_CODEC_UNINITIALIZED;

}