Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1039)

Unified Diff: webrtc/media/base/videoframe.h

Issue 2285693002: New static I420Buffer::Rotate method, to replace GetCopyWithRotationApplied. (Closed)
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/media/base/videoframe.h
diff --git a/webrtc/media/base/videoframe.h b/webrtc/media/base/videoframe.h
index a1393499f9e72742ba5792e790c09cf5fe52baf5..19f0e6c99ea2245d8e7cecdb8eeb02e26a0e0315 100644
--- a/webrtc/media/base/videoframe.h
+++ b/webrtc/media/base/videoframe.h
@@ -71,9 +71,9 @@ class VideoFrame {
// Return a copy of frame which has its pending rotation applied. The
// ownership of the returned frame is held by this frame.
- // TODO(nisse): Deprecated. Should be moved or deleted in the
- // cricket::VideoFrame and webrtc::VideoFrame merge, possibly with a helper
- // method on VideoFrameBuffer.
+ // TODO(nisse): Deprecated, no longer used within webrtc. Should be
+ // deleted as soon as downstream applications are updated. Use
+ // webrtc::VideoFrameBuffer::Rotate instead.
virtual const VideoFrame* GetCopyWithRotationApplied() const = 0;
// Converts the I420 data to RGB of a certain type such as ARGB and ABGR.

Powered by Google App Engine
This is Rietveld 408576698