Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Side by Side Diff: webrtc/media/base/videoframe.h

Issue 2285693002: New static I420Buffer::Rotate method, to replace GetCopyWithRotationApplied. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2004 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2004 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 53 matching lines...) Expand 10 before | Expand all | Expand 10 after
64 64
65 // TODO(nisse): Deprecated, to be deleted in the cricket::VideoFrame and 65 // TODO(nisse): Deprecated, to be deleted in the cricket::VideoFrame and
66 // webrtc::VideoFrame merge. To make a copy, use the cricket::WebRtcVideoFrame 66 // webrtc::VideoFrame merge. To make a copy, use the cricket::WebRtcVideoFrame
67 // constructor passing video_frame_buffer(), rotation() and timestamp_us() as 67 // constructor passing video_frame_buffer(), rotation() and timestamp_us() as
68 // arguments. 68 // arguments.
69 virtual VideoFrame *Copy() const = 0; 69 virtual VideoFrame *Copy() const = 0;
70 70
71 // Return a copy of frame which has its pending rotation applied. The 71 // Return a copy of frame which has its pending rotation applied. The
72 // ownership of the returned frame is held by this frame. 72 // ownership of the returned frame is held by this frame.
73 73
74 // TODO(nisse): Deprecated. Should be moved or deleted in the 74 // TODO(nisse): Deprecated, no longer used within webrtc. Should be
75 // cricket::VideoFrame and webrtc::VideoFrame merge, possibly with a helper 75 // deleted as soon as downstream applications are updated. Use
76 // method on VideoFrameBuffer. 76 // webrtc::VideoFrameBuffer::Rotate instead.
77 virtual const VideoFrame* GetCopyWithRotationApplied() const = 0; 77 virtual const VideoFrame* GetCopyWithRotationApplied() const = 0;
78 78
79 // Converts the I420 data to RGB of a certain type such as ARGB and ABGR. 79 // Converts the I420 data to RGB of a certain type such as ARGB and ABGR.
80 // Returns the frame's actual size, regardless of whether it was written or 80 // Returns the frame's actual size, regardless of whether it was written or
81 // not (like snprintf). Parameters size and stride_rgb are in units of bytes. 81 // not (like snprintf). Parameters size and stride_rgb are in units of bytes.
82 // If there is insufficient space, nothing is written. 82 // If there is insufficient space, nothing is written.
83 83
84 // TODO(nisse): Deprecated. Should be moved or deleted in the 84 // TODO(nisse): Deprecated. Should be moved or deleted in the
85 // cricket::VideoFrame and webrtc::VideoFrame merge. Use 85 // cricket::VideoFrame and webrtc::VideoFrame merge. Use
86 // libyuv::ConvertFromI420 directly instead. 86 // libyuv::ConvertFromI420 directly instead.
(...skipping 11 matching lines...) Expand all
98 static bool Validate(uint32_t fourcc, 98 static bool Validate(uint32_t fourcc,
99 int w, 99 int w,
100 int h, 100 int h,
101 const uint8_t* sample, 101 const uint8_t* sample,
102 size_t sample_size); 102 size_t sample_size);
103 }; 103 };
104 104
105 } // namespace cricket 105 } // namespace cricket
106 106
107 #endif // WEBRTC_MEDIA_BASE_VIDEOFRAME_H_ 107 #endif // WEBRTC_MEDIA_BASE_VIDEOFRAME_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698