Remove Chromium Clang warnings only on Windows.

Remove Chromium Clang warnings only on Windows.

A previous CL (https://codereview.webrtc.org/2281513002) broke Windows, Mac and Linux bots in WebRTC's Chromium FYI, by suppressing these warnings when they hadn't been set.

This CL fixes it suppressing warnings only on Windows.

Example failures:
https://build.chromium.org/p/chromium.webrtc.fyi/builders/Win%20Builder/builds/6540
https://build.chromium.org/p/chromium.webrtc.fyi/builders/Mac%20Builder/builds/16588
https://build.chromium.org/p/chromium.webrtc.fyi/builders/Linux%20Builder/builds/9655

BUG=webrtc:6255
NOTRY=True

Committed: https://crrev.com/3e3b6f2805d34f824b2606720273d96f5b7b5cc9
Cr-Commit-Position: refs/heads/master@{#13951}

[ehmaldonado_webrtc, 2016-08-29 08:28:13]

ehmaldonado@webrtc.org changed reviewers:
+ kjellander@webrtc.org

[ehmaldonado_webrtc, 2016-08-29 08:28:14]

I think this is it. It fails in the step when it tries to generate the build
files without patch.

[ehmaldonado_webrtc, 2016-08-29 08:41:00]

Description was changed from

==========
Fix Chromium FYI bots.

BUG=
==========

to

==========
Fix Chromium FYI bots.

BUG=
NOTRY=True
==========

[kjellander_webrtc, 2016-08-29 08:42:09]

Please:
1. Update the description to describe what you're actually doing (only remove
Chromium clang warnings on Windows).
2. Reference the CL that broke, which you're trying to fix (
https://codereview.webrtc.org/2281513002)
3. Run at least compilation for each of our own platforms. There's always a risk
that something else was submitted in the window between your CL and this one.
4. Add BUG= reference (the GN migration bug is fine)

[ehmaldonado_webrtc, 2016-08-29 08:48:55]

Description was changed from

==========
Fix Chromium FYI bots.

BUG=
NOTRY=True
==========

to

==========
Remove Chromium Clang warnings only on Windows.

A previous CL (https://codereview.webrtc.org/2281513002) broke Windows, Mac and
Linux bots in WebRTC's Chromium FYI, by suppressing these warnings when they
hadn't been set.

This CL fixes it, by suppressing warnings only on Windows.

Example failures:
https://build.chromium.org/p/chromium.webrtc.fyi/builders/Win%20Builder/build...
https://build.chromium.org/p/chromium.webrtc.fyi/builders/Mac%20Builder/build...
https://build.chromium.org/p/chromium.webrtc.fyi/builders/Linux%20Builder/bui...

BUG=webrtc:6255
NOTRY=True
==========

[ehmaldonado_webrtc, 2016-08-29 08:49:23]

Description was changed from

==========
Remove Chromium Clang warnings only on Windows.

A previous CL (https://codereview.webrtc.org/2281513002) broke Windows, Mac and
Linux bots in WebRTC's Chromium FYI, by suppressing these warnings when they
hadn't been set.

This CL fixes it, by suppressing warnings only on Windows.

Example failures:
https://build.chromium.org/p/chromium.webrtc.fyi/builders/Win%20Builder/build...
https://build.chromium.org/p/chromium.webrtc.fyi/builders/Mac%20Builder/build...
https://build.chromium.org/p/chromium.webrtc.fyi/builders/Linux%20Builder/bui...

BUG=webrtc:6255
NOTRY=True
==========

to

==========
Remove Chromium Clang warnings only on Windows.

A previous CL (https://codereview.webrtc.org/2281513002) broke Windows, Mac and
Linux bots in WebRTC's Chromium FYI, by suppressing these warnings when they
hadn't been set.

This CL fixes it suppressing warnings only on Windows.

Example failures:
https://build.chromium.org/p/chromium.webrtc.fyi/builders/Win%20Builder/build...
https://build.chromium.org/p/chromium.webrtc.fyi/builders/Mac%20Builder/build...
https://build.chromium.org/p/chromium.webrtc.fyi/builders/Linux%20Builder/bui...

BUG=webrtc:6255
NOTRY=True
==========

[ehmaldonado_webrtc, 2016-08-29 08:58:23]

On 2016/08/29 08:42:09, kjellander_webrtc wrote:
> Please:
> 1. Update the description to describe what you're actually doing (only remove
> Chromium clang warnings on Windows).
> 2. Reference the CL that broke, which you're trying to fix (
> https://codereview.webrtc.org/2281513002)
> 3. Run at least compilation for each of our own platforms. There's always a
risk
> that something else was submitted in the window between your CL and this one.
> 4. Add BUG= reference (the GN migration bug is fine)

PTAL

[kjellander_webrtc, 2016-08-29 09:27:09]

lgtm
the red chromium trybots seem to be failing on unrelated issues.

[ehmaldonado_webrtc, 2016-08-29 09:29:11]

The CQ bit was checked by ehmaldonado@webrtc.org

[commit-bot: I haz the power, 2016-08-29 09:29:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-08-29 09:56:08]

Description was changed from

==========
Remove Chromium Clang warnings only on Windows.

A previous CL (https://codereview.webrtc.org/2281513002) broke Windows, Mac and
Linux bots in WebRTC's Chromium FYI, by suppressing these warnings when they
hadn't been set.

This CL fixes it suppressing warnings only on Windows.

Example failures:
https://build.chromium.org/p/chromium.webrtc.fyi/builders/Win%20Builder/build...
https://build.chromium.org/p/chromium.webrtc.fyi/builders/Mac%20Builder/build...
https://build.chromium.org/p/chromium.webrtc.fyi/builders/Linux%20Builder/bui...

BUG=webrtc:6255
NOTRY=True
==========

to

==========
Remove Chromium Clang warnings only on Windows.

A previous CL (https://codereview.webrtc.org/2281513002) broke Windows, Mac and
Linux bots in WebRTC's Chromium FYI, by suppressing these warnings when they
hadn't been set.

This CL fixes it suppressing warnings only on Windows.

Example failures:
https://build.chromium.org/p/chromium.webrtc.fyi/builders/Win%20Builder/build...
https://build.chromium.org/p/chromium.webrtc.fyi/builders/Mac%20Builder/build...
https://build.chromium.org/p/chromium.webrtc.fyi/builders/Linux%20Builder/bui...

BUG=webrtc:6255
NOTRY=True
==========

[commit-bot: I haz the power, 2016-08-29 09:56:09]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-08-29 09:56:17]

Description was changed from

==========
Remove Chromium Clang warnings only on Windows.

A previous CL (https://codereview.webrtc.org/2281513002) broke Windows, Mac and
Linux bots in WebRTC's Chromium FYI, by suppressing these warnings when they
hadn't been set.

This CL fixes it suppressing warnings only on Windows.

Example failures:
https://build.chromium.org/p/chromium.webrtc.fyi/builders/Win%20Builder/build...
https://build.chromium.org/p/chromium.webrtc.fyi/builders/Mac%20Builder/build...
https://build.chromium.org/p/chromium.webrtc.fyi/builders/Linux%20Builder/bui...

BUG=webrtc:6255
NOTRY=True
==========

to

==========
Remove Chromium Clang warnings only on Windows.

A previous CL (https://codereview.webrtc.org/2281513002) broke Windows, Mac and
Linux bots in WebRTC's Chromium FYI, by suppressing these warnings when they
hadn't been set.

This CL fixes it suppressing warnings only on Windows.

Example failures:
https://build.chromium.org/p/chromium.webrtc.fyi/builders/Win%20Builder/build...
https://build.chromium.org/p/chromium.webrtc.fyi/builders/Mac%20Builder/build...
https://build.chromium.org/p/chromium.webrtc.fyi/builders/Linux%20Builder/bui...

BUG=webrtc:6255
NOTRY=True

Committed: https://crrev.com/3e3b6f2805d34f824b2606720273d96f5b7b5cc9
Cr-Commit-Position: refs/heads/master@{#13951}
==========

[commit-bot: I haz the power, 2016-08-29 09:56:17]

Patchset 1 (id:??) landed as
https://crrev.com/3e3b6f2805d34f824b2606720273d96f5b7b5cc9
Cr-Commit-Position: refs/heads/master@{#13951}