Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 2279283002: Do not report bucket delay when pacer is paused. (Closed)

Created:
4 years, 3 months ago by åsapersson
Modified:
4 years, 3 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Do not report bucket delay for stats when pacer is paused (zero returned). Avoids reporting a growing delay (i.e. time b/w current time and oldest packet in the pacer). BUG=webrtc:6253 Committed: https://crrev.com/14f1250f47be2190ce96840b04fe4289c796a590 Cr-Commit-Position: refs/heads/master@{#14118}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -1 line) Patch
M webrtc/modules/congestion_controller/congestion_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/congestion_controller/congestion_controller_unittest.cc View 2 chunks +17 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (9 generated)
åsapersson
4 years, 3 months ago (2016-08-26 15:10:12 UTC) #3
sprang_webrtc
lgtm
4 years, 3 months ago (2016-09-07 13:20:32 UTC) #6
stefan-webrtc
lgtm
4 years, 3 months ago (2016-09-07 13:25:08 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2279283002/1
4 years, 3 months ago (2016-09-07 13:31:17 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_clang_dbg/builds/15870)
4 years, 3 months ago (2016-09-07 13:37:31 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2279283002/1
4 years, 3 months ago (2016-09-08 05:33:57 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-08 06:14:53 UTC) #15
commit-bot: I haz the power
4 years, 3 months ago (2016-09-08 06:15:02 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/14f1250f47be2190ce96840b04fe4289c796a590
Cr-Commit-Position: refs/heads/master@{#14118}

Powered by Google App Engine
This is Rietveld 408576698