Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 2276833003: Change RtpSender::OnReceiveNACK name and signature (Closed)

Created:
4 years, 3 months ago by danilchap
Modified:
4 years, 3 months ago
Reviewers:
philipel
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, stefan-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Change RtpSender::OnReceiveNACK name and signature Name changed to follow style. list replaced with vector to decrease number of included headers. R=philipel@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/2800d74fcf6cf54d4cdf24bddad3486abdec934d

Patch Set 1 #

Patch Set 2 : -one more <list> include #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -16 lines) Patch
M webrtc/modules/rtp_rtcp/source/rtcp_receiver.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_receiver_help.h View 2 chunks +1 line, -2 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.h View 2 chunks +1 line, -2 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_sender.h View 1 2 chunks +1 line, -2 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_sender.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_sender_unittest.cc View 3 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
danilchap
This CL address two comments to CL https://codereview.webrtc.org/2274573002/ I agree they are positive steps, but ...
4 years, 3 months ago (2016-08-24 15:44:51 UTC) #2
philipel
lgtm
4 years, 3 months ago (2016-08-26 14:23:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2276833003/20001
4 years, 3 months ago (2016-08-26 14:31:14 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_rel on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_rel/builds/15880)
4 years, 3 months ago (2016-08-26 14:45:32 UTC) #7
danilchap
4 years, 3 months ago (2016-08-26 16:49:10 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
2800d74fcf6cf54d4cdf24bddad3486abdec934d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698