webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.h - Issue 2276833003: Change RtpSender::OnReceiveNACK name and signature

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.h

Issue 2276833003: Change RtpSender::OnReceiveNACK name and signature (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: -one more <list> include Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.h

diff --git a/webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.h b/webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.h

index f8fb21130c74acdac21c1bebdd9a756c41bb61aa..80e76e36bf3be6a1d9ce62fbce1194eea0f10f8c 100644

--- a/webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.h

+++ b/webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.h

@@ -11,7 +11,6 @@

#ifndef WEBRTC_MODULES_RTP_RTCP_SOURCE_RTP_RTCP_IMPL_H_

#define WEBRTC_MODULES_RTP_RTCP_SOURCE_RTP_RTCP_IMPL_H_

-#include <list>

#include <set>

#include <utility>

#include <vector>

@@ -312,7 +311,7 @@ class ModuleRtpRtcpImpl : public RtpRtcp {

StreamDataCountersCallback* GetSendChannelRtpStatisticsCallback()

const override;

- void OnReceivedNACK(const std::list<uint16_t>& nack_sequence_numbers);

+ void OnReceivedNack(const std::vector<uint16_t>& nack_sequence_numbers);

void OnReceivedRtcpReportBlocks(const ReportBlockList& report_blocks);

void OnRequestSendReport();

« no previous file with comments | « webrtc/modules/rtp_rtcp/source/rtcp_receiver_help.h ('k') | webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.cc » ('j') | no next file with comments »