webrtc/modules/rtp_rtcp/source/producer_fec_unittest.cc - Issue 2276473002: Rename FrameGenerator -> UlpfecPacketGenerator. (pt. 6b)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/rtp_rtcp/source/producer_fec_unittest.cc

Issue 2276473002: Rename FrameGenerator -> UlpfecPacketGenerator. (pt. 6b) (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@headers-pt5-add_flexfec

Patch Set: Rebase. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: webrtc/modules/rtp_rtcp/source/producer_fec_unittest.cc

diff --git a/webrtc/modules/rtp_rtcp/source/producer_fec_unittest.cc b/webrtc/modules/rtp_rtcp/source/producer_fec_unittest.cc

index ae51605d68834c39d55fbcb0d0d2ba8111381ffc..e94b487a15a9065015dd5b0e7730f3b8113b1a66 100644

--- a/webrtc/modules/rtp_rtcp/source/producer_fec_unittest.cc

+++ b/webrtc/modules/rtp_rtcp/source/producer_fec_unittest.cc

@@ -25,8 +25,8 @@ constexpr uint8_t kFecPayloadType = 96;

constexpr uint8_t kRedPayloadType = 97;

} // namespace

-using ::webrtc::test::fec::FrameGenerator;

using ::webrtc::test::fec::RawRtpPacket;

danilchap 2016/09/21 11:26:45 move using inside unnamed namespace and remove ::w

brandtr 2016/09/21 12:54:07 Done.

+using ::webrtc::test::fec::UlpfecPacketGenerator;

void VerifyHeader(uint16_t seq_num,

uint32_t timestamp,

@@ -50,7 +50,7 @@ void VerifyHeader(uint16_t seq_num,

class ProducerFecTest : public ::testing::Test {

protected:

ProducerFec producer_;

- FrameGenerator generator_;

+ UlpfecPacketGenerator generator_;

};

// Verifies bug found via fuzzing, where a gap in the packet sequence caused us

« webrtc/modules/rtp_rtcp/source/fec_receiver_unittest.cc ('K') | « webrtc/modules/rtp_rtcp/source/fec_test_helper.cc ('k') | no next file » | no next file with comments »