Rename FrameGenerator -> UlpfecPacketGenerator. (pt. 6b)

Rename FrameGenerator -> UlpfecPacketGenerator.

Also, change order of definition in fec_test_helper.{h,cc}.

This CL should have no implications on functionality. It is in preparation
for a FlexfecPacketGenerator class, which will be used in the FlexFEC
unit tests.

R=danilchap@webrtc.org
BUG=webrtc:5654
Committed: https://crrev.com/a4545ee4bba826e61f23530b49114a9ddb3c60c2
Cr-Commit-Position: refs/heads/master@{#14471}

[brandtr, 2016-08-23 13:26:33]

Related to your comment about why several packet generators are needed: they
generate different types of packets.

Soon there will be a Flexfec packet generator as well. That
class may be able to reuse parts of the Ulpfec packet generator. (The main
difference is that Ulpfec is encapsulated in RED, whereas Flexfec is not.)

[brandtr, 2016-08-23 14:25:38]

Patchset #2 (id:20001) has been deleted

[brandtr, 2016-08-24 06:26:02]

Patchset #4 (id:80001) has been deleted

[brandtr, 2016-08-24 06:26:20]

Patchset #3 (id:60001) has been deleted

[brandtr, 2016-08-25 13:24:46]

Rebase.

[brandtr, 2016-08-30 07:14:31]

Rebase.

[brandtr, 2016-08-30 14:32:03]

Description was changed from

==========
Rename FrameGenerator -> UlpfecPacketGenerator.

Also, change order of definition in fec_test_helper.{h,cc}.

This CL should have no implications on functionality. It is in preparation
for a FlexfecPacketGenerator class, which will be used in the FlexFEC
unit tests.

R=danilchap@webrtc.org
BUG=webrtc:5654
==========

to

==========
Rename FrameGenerator -> UlpfecPacketGenerator.

Also, change order of definition in fec_test_helper.{h,cc}.

This CL should have no implications on functionality. It is in preparation
for a FlexfecPacketGenerator class, which will be used in the FlexFEC
unit tests.

R=danilchap@webrtc.org
BUG=webrtc:5654
==========

[brandtr, 2016-08-30 14:40:16]

Rebase.

[brandtr, 2016-09-02 09:41:38]

Rebase.

[brandtr, 2016-09-05 14:14:41]

Rebase

[brandtr, 2016-09-06 14:36:33]

Rebase.

[brandtr, 2016-09-13 10:57:09]

Rebase.

[brandtr, 2016-09-14 11:43:56]

Rebase.

[brandtr, 2016-09-21 10:51:05]

Rebase.

[danilchap, 2016-09-21 11:26:45]

lgtm
feel free to address nits in another cl if you find them irrelevant for this CL
subject.

https://codereview.webrtc.org/2276473002/diff/320001/webrtc/modules/rtp_rtcp/...
File webrtc/modules/rtp_rtcp/source/fec_receiver_unittest.cc (right):

https://codereview.webrtc.org/2276473002/diff/320001/webrtc/modules/rtp_rtcp/...
webrtc/modules/rtp_rtcp/source/fec_receiver_unittest.cc:31: using ::testing::_;
move all using inside unnamed namespace

https://codereview.webrtc.org/2276473002/diff/320001/webrtc/modules/rtp_rtcp/...
webrtc/modules/rtp_rtcp/source/fec_receiver_unittest.cc:38: using
::webrtc::test::fec::UlpfecPacketGenerator;
'::webrtc::' can be removed actually (that likely opposite to what I comment
before, but I reread guidance more carefully)

https://codereview.webrtc.org/2276473002/diff/320001/webrtc/modules/rtp_rtcp/...
File webrtc/modules/rtp_rtcp/source/producer_fec_unittest.cc (right):

https://codereview.webrtc.org/2276473002/diff/320001/webrtc/modules/rtp_rtcp/...
webrtc/modules/rtp_rtcp/source/producer_fec_unittest.cc:28: using
::webrtc::test::fec::RawRtpPacket;
move using inside unnamed namespace and remove ::webrtc:: prefix

[brandtr, 2016-09-21 12:02:06]

Thanks!

Nits will be addressed in https://codereview.webrtc.org/2273353002/

[brandtr, 2016-09-21 12:54:07]

Response here, but changes added to https://codereview.webrtc.org/2273353002/.

https://codereview.webrtc.org/2276473002/diff/320001/webrtc/modules/rtp_rtcp/...
File webrtc/modules/rtp_rtcp/source/fec_receiver_unittest.cc (right):

https://codereview.webrtc.org/2276473002/diff/320001/webrtc/modules/rtp_rtcp/...
webrtc/modules/rtp_rtcp/source/fec_receiver_unittest.cc:31: using ::testing::_;
On 2016/09/21 11:26:45, danilchap wrote:
> move all using inside unnamed namespace

Done.

https://codereview.webrtc.org/2276473002/diff/320001/webrtc/modules/rtp_rtcp/...
webrtc/modules/rtp_rtcp/source/fec_receiver_unittest.cc:38: using
::webrtc::test::fec::UlpfecPacketGenerator;
On 2016/09/21 11:26:45, danilchap wrote:
> '::webrtc::' can be removed actually (that likely opposite to what I comment
> before, but I reread guidance more carefully)

Ok :)

Changing in Ulpfec/Flexfec unit tests as well.

https://codereview.webrtc.org/2276473002/diff/320001/webrtc/modules/rtp_rtcp/...
File webrtc/modules/rtp_rtcp/source/producer_fec_unittest.cc (right):

https://codereview.webrtc.org/2276473002/diff/320001/webrtc/modules/rtp_rtcp/...
webrtc/modules/rtp_rtcp/source/producer_fec_unittest.cc:28: using
::webrtc::test::fec::RawRtpPacket;
On 2016/09/21 11:26:45, danilchap wrote:
> move using inside unnamed namespace and remove ::webrtc:: prefix

Done.

[brandtr, 2016-09-27 08:20:39]

Rebase.

[brandtr, 2016-10-03 08:55:43]

The CQ bit was checked by brandtr@webrtc.org

[brandtr, 2016-10-03 08:55:44]

The patchset sent to the CQ was uploaded after l-g-t-m from danilchap@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2276473002/#ps360001 (title:
"gmock/test paths.")

[commit-bot: I haz the power, 2016-10-03 08:55:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-10-03 09:58:47]

Description was changed from

==========
Rename FrameGenerator -> UlpfecPacketGenerator.

Also, change order of definition in fec_test_helper.{h,cc}.

This CL should have no implications on functionality. It is in preparation
for a FlexfecPacketGenerator class, which will be used in the FlexFEC
unit tests.

R=danilchap@webrtc.org
BUG=webrtc:5654
==========

to

==========
Rename FrameGenerator -> UlpfecPacketGenerator.

Also, change order of definition in fec_test_helper.{h,cc}.

This CL should have no implications on functionality. It is in preparation
for a FlexfecPacketGenerator class, which will be used in the FlexFEC
unit tests.

R=danilchap@webrtc.org
BUG=webrtc:5654
==========

[commit-bot: I haz the power, 2016-10-03 09:58:48]

Committed patchset #16 (id:360001)

[commit-bot: I haz the power, 2016-10-03 09:59:00]

Description was changed from

==========
Rename FrameGenerator -> UlpfecPacketGenerator.

Also, change order of definition in fec_test_helper.{h,cc}.

This CL should have no implications on functionality. It is in preparation
for a FlexfecPacketGenerator class, which will be used in the FlexFEC
unit tests.

R=danilchap@webrtc.org
BUG=webrtc:5654
==========

to

==========
Rename FrameGenerator -> UlpfecPacketGenerator.

Also, change order of definition in fec_test_helper.{h,cc}.

This CL should have no implications on functionality. It is in preparation
for a FlexfecPacketGenerator class, which will be used in the FlexFEC
unit tests.

R=danilchap@webrtc.org
BUG=webrtc:5654

Committed: https://crrev.com/a4545ee4bba826e61f23530b49114a9ddb3c60c2
Cr-Commit-Position: refs/heads/master@{#14471}
==========

[commit-bot: I haz the power, 2016-10-03 09:59:01]

Patchset 16 (id:??) landed as
https://crrev.com/a4545ee4bba826e61f23530b49114a9ddb3c60c2
Cr-Commit-Position: refs/heads/master@{#14471}