Migrated GN target :g722_test

Migrated GN target :g722_test

Migrated GN target :g722_test from
webrtc/modules/audio_coding/codecs/g722/g722.gypi

NOTRY=True

BUG=webrtc:6191
Committed: https://crrev.com/9a11784a7f04c629bc1372f2f2d29924f606b0fd
Cr-Commit-Position: refs/heads/master@{#13865}

[aleloi, 2016-08-23 09:39:40]

Patchset #2 (id:20001) has been deleted

[aleloi, 2016-08-23 09:39:46]

Patchset #2 (id:40001) has been deleted

[aleloi, 2016-08-23 09:44:52]

aleloi@webrtc.org changed reviewers:
+ kjellander@webrtc.org

[aleloi, 2016-08-23 09:44:53]

Hi! A new GN migration. Ptal!

https://codereview.webrtc.org/2275463002/diff/1/webrtc/modules/audio_coding/B...
File webrtc/modules/audio_coding/BUILD.gn (right):

https://codereview.webrtc.org/2275463002/diff/1/webrtc/modules/audio_coding/B...
webrtc/modules/audio_coding/BUILD.gn:1551: "../..:webrtc_common",
Added missing dependency from webrtc/typedefs.h

https://codereview.webrtc.org/2275463002/diff/1/webrtc/modules/audio_coding/c...
File webrtc/modules/audio_coding/codecs/g722/g722.gypi (right):

https://codereview.webrtc.org/2275463002/diff/1/webrtc/modules/audio_coding/c...
webrtc/modules/audio_coding/codecs/g722/g722.gypi:37:
'<(webrtc_root)/common.gyp:webrtc_common'
Also added the missing dependency in the gyp file.

https://codereview.webrtc.org/2275463002/diff/60001/webrtc/modules/audio_codi...
File webrtc/modules/audio_coding/BUILD.gn (right):

https://codereview.webrtc.org/2275463002/diff/60001/webrtc/modules/audio_codi...
webrtc/modules/audio_coding/BUILD.gn:1550: public_configs = [
"../..:common_inherited_config" ]
It couldn't find __android_log_print. I think that WEBRTC_ANDROID (which is set
in common_inherited_config) was not defined.

A question: should these lines be present for all targets?

[aleloi, 2016-08-23 11:25:04]

Patchset #3 (id:80001) has been deleted

[aleloi, 2016-08-23 11:33:26]

Patchset #2 (id:60001) has been deleted

[kjellander_webrtc, 2016-08-23 11:39:31]

lgtm

[aleloi, 2016-08-23 11:43:00]

Patchset #2 (id:100001) has been deleted

[aleloi, 2016-08-23 11:46:09]

Patchset #1 (id:1) has been deleted

[aleloi, 2016-08-23 12:11:22]

On 2016/08/23 11:39:31, kjellander_webrtc wrote:
> lgtm

Rietveld doesn't seem to add my dependency as a dependency. I think it is
therefore I get patch errors. Although when I upload from terminal, there is a
message
"
The current branch (g722_test) is tracking a local branch (g711_test) with an
associated CL.
Adding https://codereview.webrtc.org/2273623002/#ps80001 as a dependency
patchset.
"

[aleloi, 2016-08-23 12:13:41]

Patchset #2 (id:140001) has been deleted

[aleloi, 2016-08-23 12:19:49]

Patch problem now solved. My hypothesis is that the cl script added a removed
patch set as a dependency. Does it look for the most recent patch set locally? I
see there is a 'rietveldpatchset' variable in the branch descriptions in
.git/config.

[kjellander_webrtc, 2016-08-23 12:35:50]

On 2016/08/23 12:19:49, aleloi wrote:
> Patch problem now solved. My hypothesis is that the cl script added a removed
> patch set as a dependency. Does it look for the most recent patch set locally?
I
> see there is a 'rietveldpatchset' variable in the branch descriptions in
> .git/config.

I'm sorry but I never bothered figuring out the details on how dependent CLs are
working in Rietveld.
Still lgtm

[aleloi, 2016-08-23 14:35:45]

The CQ bit was checked by aleloi@webrtc.org

[commit-bot: I haz the power, 2016-08-23 14:35:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-23 14:35:52]

This CL has an open dependency (Issue 2273623002 Patch 100001). Please resolve
the dependency and try again.
If you are sure that there is no real dependency, please use one of the options
listed in https://goo.gl/9Es4OR to land the CL.

[aleloi, 2016-08-23 15:27:57]

The CQ bit was checked by aleloi@webrtc.org

[commit-bot: I haz the power, 2016-08-23 15:28:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-08-23 15:36:19]

Description was changed from

==========
Migrated GN target :g722_test

Migrated GN target :g722_test from
webrtc/modules/audio_coding/codecs/g722/g722.gypi

NOTRY=True

BUG=webrtc:6191
==========

to

==========
Migrated GN target :g722_test

Migrated GN target :g722_test from
webrtc/modules/audio_coding/codecs/g722/g722.gypi

NOTRY=True

BUG=webrtc:6191

Committed: https://crrev.com/9a11784a7f04c629bc1372f2f2d29924f606b0fd
Cr-Commit-Position: refs/heads/master@{#13865}
==========

[commit-bot: I haz the power, 2016-08-23 15:36:20]

Committed patchset #2 (id:160001)

[commit-bot: I haz the power, 2016-08-23 15:36:20]

Patchset 2 (id:??) landed as
https://crrev.com/9a11784a7f04c629bc1372f2f2d29924f606b0fd
Cr-Commit-Position: refs/heads/master@{#13865}