Migrated GN target :g711_test

Migrated GN target :g711_test

Migrated GN target :g711_test from
webrtc/modules/audio_coding/codecs/g711/g711.gypi

NOTRY=True

BUG=webrtc:6191
Committed: https://crrev.com/16f55a10c4e73e46a58eb45587841914e6b0d851
Cr-Commit-Position: refs/heads/master@{#13864}

[aleloi, 2016-08-23 09:53:21]

aleloi@webrtc.org changed reviewers:
+ kjellander@webrtc.org

[aleloi, 2016-08-23 09:53:22]

Hi! A new GN migration. Could you ptal?

[aleloi, 2016-08-23 11:20:18]

https://codereview.webrtc.org/2273623002/diff/40001/webrtc/base/BUILD.gn
File webrtc/base/BUILD.gn (right):

https://codereview.webrtc.org/2273623002/diff/40001/webrtc/base/BUILD.gn#newc...
webrtc/base/BUILD.gn:176: 
This is a linker directive that should make the linker find __android_log_print
on Android. Took lots of time to track down...

[aleloi, 2016-08-23 11:20:45]

Patchset #3 (id:40001) has been deleted

[aleloi, 2016-08-23 11:24:54]

Patchset #2 (id:20001) has been deleted

[aleloi, 2016-08-23 11:35:20]

Patchset #3 (id:80001) has been deleted

[aleloi, 2016-08-23 12:13:18]

Patchset #1 (id:1) has been deleted

[kjellander_webrtc, 2016-08-23 12:38:15]

https://codereview.webrtc.org/2273623002/diff/100001/webrtc/base/BUILD.gn
File webrtc/base/BUILD.gn (right):

https://codereview.webrtc.org/2273623002/diff/100001/webrtc/base/BUILD.gn#new...
webrtc/base/BUILD.gn:175: libs += [ "log" ]
So, how come this is not needed for GYP? I think we should keep the targets in
sync.

[aleloi, 2016-08-23 12:46:07]

On 2016/08/23 12:38:15, kjellander_webrtc wrote:
> https://codereview.webrtc.org/2273623002/diff/100001/webrtc/base/BUILD.gn
> File webrtc/base/BUILD.gn (right):
> 
>
https://codereview.webrtc.org/2273623002/diff/100001/webrtc/base/BUILD.gn#new...
> webrtc/base/BUILD.gn:175: libs += [ "log" ]
> So, how come this is not needed for GYP? I think we should keep the targets in
> sync.

I think it is. I think the lib is added to the linker by some other target, or
that no one has tried to compile the g7** tests for Android. I'll add it.

[aleloi, 2016-08-23 12:59:46]

Now added the linker lib to Gyp as well.

[kjellander_webrtc, 2016-08-23 14:20:10]

lgtm

[aleloi, 2016-08-23 14:35:23]

The CQ bit was checked by aleloi@webrtc.org

[commit-bot: I haz the power, 2016-08-23 14:35:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-08-23 15:08:27]

Committed patchset #3 (id:120001)

[commit-bot: I haz the power, 2016-08-23 15:08:34]

Description was changed from

==========
Migrated GN target :g711_test

Migrated GN target :g711_test from
webrtc/modules/audio_coding/codecs/g711/g711.gypi

NOTRY=True

BUG=webrtc:6191
==========

to

==========
Migrated GN target :g711_test

Migrated GN target :g711_test from
webrtc/modules/audio_coding/codecs/g711/g711.gypi

NOTRY=True

BUG=webrtc:6191

Committed: https://crrev.com/16f55a10c4e73e46a58eb45587841914e6b0d851
Cr-Commit-Position: refs/heads/master@{#13864}
==========

[commit-bot: I haz the power, 2016-08-23 15:08:36]

Patchset 3 (id:??) landed as
https://crrev.com/16f55a10c4e73e46a58eb45587841914e6b0d851
Cr-Commit-Position: refs/heads/master@{#13864}