Minor fixes in FEC and RtpSender{,Video}. (pt. 2)

Minor fixes in FEC and RtpSender{,Video}

- Rename GetNumberOfFecPackets -> NumFecPackets and
  PacketOverhead -> MaxPacketOverhead in ForwardErrorCorrection.
- Rename FECPacketOverhead -> FecPacketOverhead in ProducerFec.
- Move ownership of ForwardErrorCorrection from RTPSenderVideo
  to ProducerFec.
- Make MaxPacketOverhead a member function of ForwardErrorCorrection.
  This will allow for changing it, based on FEC header types, later on.

BUG=webrtc:5654
Committed: https://crrev.com/6631e8a21bd1e1335dc056f0f205643bf662caa0
Cr-Commit-Position: refs/heads/master@{#14194}

[brandtr, 2016-08-23 07:54:45]

Description was changed from

==========
Minor fixes in ForwardErrorCorrection and ProducerFec.

- Rename GetNumberOfFecPackets -> GetNumberOfFecPackets and
  PacketOverhead -> MaxPacketOverhead in ForwardErrorCorrection.
- Rename FECPacketOverhead -> FecPacketOverhead in ProducerFec.
- Remove pointer indirection of fec_ member in ProducerFec.
- Make MaxPacketOverhead a member function of ForwardErrorCorrection.
  This will allow for changing it, based on FEC header types, later on.

BUG=webrtc:5654
==========

to

==========
Minor fixes in ForwardErrorCorrection and ProducerFec.

- Rename GetNumberOfFecPackets -> GetNumberOfFecPackets and
  PacketOverhead -> MaxPacketOverhead in ForwardErrorCorrection.
- Rename FECPacketOverhead -> FecPacketOverhead in ProducerFec.
- Remove pointer indirection of fec_ member in ProducerFec.
- Make MaxPacketOverhead a member function of ForwardErrorCorrection.
  This will allow for changing it, based on FEC header types, later on.

BUG=webrtc:5654
==========

[brandtr, 2016-08-23 08:12:11]

Description was changed from

==========
Minor fixes in ForwardErrorCorrection and ProducerFec.

- Rename GetNumberOfFecPackets -> GetNumberOfFecPackets and
  PacketOverhead -> MaxPacketOverhead in ForwardErrorCorrection.
- Rename FECPacketOverhead -> FecPacketOverhead in ProducerFec.
- Remove pointer indirection of fec_ member in ProducerFec.
- Make MaxPacketOverhead a member function of ForwardErrorCorrection.
  This will allow for changing it, based on FEC header types, later on.

BUG=webrtc:5654
==========

to

==========
Minor fixes in FEC and RtpSender{,Video}

- Rename GetNumberOfFecPackets -> GetNumberOfFecPackets and
  PacketOverhead -> MaxPacketOverhead in ForwardErrorCorrection.
- Rename FECPacketOverhead -> FecPacketOverhead in ProducerFec.
- Move ownership of ForwardErrorCorrection from RTPSenderVideo
  to ProducerFec.
- Make MaxPacketOverhead a member function of ForwardErrorCorrection.
  This will allow for changing it, based on FEC header types, later on.

BUG=webrtc:5654
==========

[brandtr, 2016-08-23 08:18:20]

brandtr@webrtc.org changed reviewers:
+ danilchap@webrtc.org, stefan@webrtc.org

[brandtr, 2016-08-23 08:18:21]

Split up previous large CL in five semi-indenpendent ones.

[danilchap, 2016-08-23 09:16:11]

Update CL descriptioin: 1st rename doesn't look correct.
lgtm % nit

https://codereview.webrtc.org/2275443002/diff/1/webrtc/modules/rtp_rtcp/sourc...
File webrtc/modules/rtp_rtcp/source/rtp_sender_video.cc (right):

https://codereview.webrtc.org/2275443002/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/rtp_sender_video.cc:29: namespace {
keep unnammed namespace inside webrtc namespace

https://codereview.webrtc.org/2275443002/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/rtp_sender_video.cc:30: 
probably nicer without extra empty lines when there is just line in the unnamed
namespace

[brandtr, 2016-08-23 09:27:02]

Description was changed from

==========
Minor fixes in FEC and RtpSender{,Video}

- Rename GetNumberOfFecPackets -> GetNumberOfFecPackets and
  PacketOverhead -> MaxPacketOverhead in ForwardErrorCorrection.
- Rename FECPacketOverhead -> FecPacketOverhead in ProducerFec.
- Move ownership of ForwardErrorCorrection from RTPSenderVideo
  to ProducerFec.
- Make MaxPacketOverhead a member function of ForwardErrorCorrection.
  This will allow for changing it, based on FEC header types, later on.

BUG=webrtc:5654
==========

to

==========
Minor fixes in FEC and RtpSender{,Video}

- Rename GetNumberOfFecPackets -> NumFecPackets and
  PacketOverhead -> MaxPacketOverhead in ForwardErrorCorrection.
- Rename FECPacketOverhead -> FecPacketOverhead in ProducerFec.
- Move ownership of ForwardErrorCorrection from RTPSenderVideo
  to ProducerFec.
- Make MaxPacketOverhead a member function of ForwardErrorCorrection.
  This will allow for changing it, based on FEC header types, later on.

BUG=webrtc:5654
==========

[brandtr, 2016-08-23 09:36:37]

https://codereview.webrtc.org/2275443002/diff/1/webrtc/modules/rtp_rtcp/sourc...
File webrtc/modules/rtp_rtcp/source/rtp_sender_video.cc (right):

https://codereview.webrtc.org/2275443002/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/rtp_sender_video.cc:29: namespace {
On 2016/08/23 09:16:11, danilchap wrote:
> keep unnammed namespace inside webrtc namespace

Done.

https://codereview.webrtc.org/2275443002/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/rtp_sender_video.cc:30: 
On 2016/08/23 09:16:11, danilchap wrote:
> probably nicer without extra empty lines when there is just line in the
unnamed
> namespace

Done.

[brandtr, 2016-08-29 09:43:50]

The CQ bit was checked by brandtr@webrtc.org

[brandtr, 2016-08-29 09:43:50]

The patchset sent to the CQ was uploaded after l-g-t-m from danilchap@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2275443002/#ps40001 (title:
"Rebase.")

[commit-bot: I haz the power, 2016-08-29 09:43:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-08-29 09:51:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-29 09:51:28]

Try jobs failed on following builders:
  android_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_rel/builds/15912)

[brandtr, 2016-08-29 10:59:17]

Need holmer's lgtm for change to fuzzer :)

[brandtr, 2016-09-05 14:16:24]

ping holmer :)

[brandtr, 2016-09-06 14:35:00]

Rebase.

[stefan-webrtc, 2016-09-13 07:20:58]

lgtm

[brandtr, 2016-09-13 09:18:03]

The CQ bit was checked by brandtr@webrtc.org

[brandtr, 2016-09-13 09:18:04]

The patchset sent to the CQ was uploaded after l-g-t-m from danilchap@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2275443002/#ps60001 (title:
"Rebase.")

[commit-bot: I haz the power, 2016-09-13 09:18:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-09-13 10:23:31]

Description was changed from

==========
Minor fixes in FEC and RtpSender{,Video}

- Rename GetNumberOfFecPackets -> NumFecPackets and
  PacketOverhead -> MaxPacketOverhead in ForwardErrorCorrection.
- Rename FECPacketOverhead -> FecPacketOverhead in ProducerFec.
- Move ownership of ForwardErrorCorrection from RTPSenderVideo
  to ProducerFec.
- Make MaxPacketOverhead a member function of ForwardErrorCorrection.
  This will allow for changing it, based on FEC header types, later on.

BUG=webrtc:5654
==========

to

==========
Minor fixes in FEC and RtpSender{,Video}

- Rename GetNumberOfFecPackets -> NumFecPackets and
  PacketOverhead -> MaxPacketOverhead in ForwardErrorCorrection.
- Rename FECPacketOverhead -> FecPacketOverhead in ProducerFec.
- Move ownership of ForwardErrorCorrection from RTPSenderVideo
  to ProducerFec.
- Make MaxPacketOverhead a member function of ForwardErrorCorrection.
  This will allow for changing it, based on FEC header types, later on.

BUG=webrtc:5654
==========

[commit-bot: I haz the power, 2016-09-13 10:23:32]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-09-13 10:23:36]

Description was changed from

==========
Minor fixes in FEC and RtpSender{,Video}

- Rename GetNumberOfFecPackets -> NumFecPackets and
  PacketOverhead -> MaxPacketOverhead in ForwardErrorCorrection.
- Rename FECPacketOverhead -> FecPacketOverhead in ProducerFec.
- Move ownership of ForwardErrorCorrection from RTPSenderVideo
  to ProducerFec.
- Make MaxPacketOverhead a member function of ForwardErrorCorrection.
  This will allow for changing it, based on FEC header types, later on.

BUG=webrtc:5654
==========

to

==========
Minor fixes in FEC and RtpSender{,Video}

- Rename GetNumberOfFecPackets -> NumFecPackets and
  PacketOverhead -> MaxPacketOverhead in ForwardErrorCorrection.
- Rename FECPacketOverhead -> FecPacketOverhead in ProducerFec.
- Move ownership of ForwardErrorCorrection from RTPSenderVideo
  to ProducerFec.
- Make MaxPacketOverhead a member function of ForwardErrorCorrection.
  This will allow for changing it, based on FEC header types, later on.

BUG=webrtc:5654

Committed: https://crrev.com/6631e8a21bd1e1335dc056f0f205643bf662caa0
Cr-Commit-Position: refs/heads/master@{#14194}
==========

[commit-bot: I haz the power, 2016-09-13 10:23:37]

Patchset 4 (id:??) landed as
https://crrev.com/6631e8a21bd1e1335dc056f0f205643bf662caa0
Cr-Commit-Position: refs/heads/master@{#14194}