Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 2274713005: GN: Fix Windows Clang errors (Closed)

Created:
4 years, 4 months ago by ehmaldonado_webrtc
Modified:
4 years, 3 months ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, perkj_webrtc, mflodman, sdk-team_agora.io
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

GN: Fix Windows Clang errors BUG=webrtc:6255 NOTRY=True Committed: https://crrev.com/4bc4d2747b297b3d770fe4bb2d6bee0786d2164a Cr-Commit-Position: refs/heads/master@{#13919}

Patch Set 1 : GN: Fix Windows Clang errors #

Patch Set 2 : It works! #

Total comments: 1

Patch Set 3 : Cleaning up. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -6 lines) Patch
M .gn View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/winsdk_samples/BUILD.gn View 1 2 chunks +22 lines, -4 lines 0 comments Download
M webrtc/base/BUILD.gn View 1 1 chunk +9 lines, -0 lines 0 comments Download
M webrtc/examples/BUILD.gn View 1 1 chunk +8 lines, -0 lines 0 comments Download
M webrtc/media/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_device/BUILD.gn View 1 1 chunk +17 lines, -0 lines 0 comments Download
M webrtc/modules/video_capture/BUILD.gn View 1 1 chunk +11 lines, -0 lines 0 comments Download
M webrtc/test/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (8 generated)
ehmaldonado_webrtc
I think this is good to go :)
4 years, 3 months ago (2016-08-25 10:48:20 UTC) #5
kjellander_webrtc
https://codereview.webrtc.org/2274713005/diff/60001/tools/gyp_flag_compare.py File tools/gyp_flag_compare.py (right): https://codereview.webrtc.org/2274713005/diff/60001/tools/gyp_flag_compare.py#newcode1 tools/gyp_flag_compare.py:1: #!/usr/bin/env python Updating this script is good, but let's ...
4 years, 3 months ago (2016-08-25 11:07:19 UTC) #6
kjellander_webrtc
I changed it to reference webrtc:6255 instead.
4 years, 3 months ago (2016-08-25 11:08:51 UTC) #8
kjellander_webrtc
Ah, only PS#2 contained the gyp compare script changes... LGTM - impressive work! I've spent ...
4 years, 3 months ago (2016-08-25 11:11:41 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2274713005/80001
4 years, 3 months ago (2016-08-25 11:14:25 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:80001)
4 years, 3 months ago (2016-08-25 11:15:43 UTC) #13
commit-bot: I haz the power
4 years, 3 months ago (2016-08-25 11:15:56 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/4bc4d2747b297b3d770fe4bb2d6bee0786d2164a
Cr-Commit-Position: refs/heads/master@{#13919}

Powered by Google App Engine
This is Rietveld 408576698