Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Unified Diff: third_party/winsdk_samples/BUILD.gn

Issue 2274713005: GN: Fix Windows Clang errors (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Cleaning up. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « .gn ('k') | webrtc/base/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/winsdk_samples/BUILD.gn
diff --git a/third_party/winsdk_samples/BUILD.gn b/third_party/winsdk_samples/BUILD.gn
index ec2d4591ee5b9f05237bd9e0255165a8f20045b6..82d12332e3f6852021aeff930c342d89d1cff61b 100644
--- a/third_party/winsdk_samples/BUILD.gn
+++ b/third_party/winsdk_samples/BUILD.gn
@@ -10,9 +10,7 @@ if (is_win) {
baseclasses_dir = "src/Samples/multimedia/directshow/baseclasses"
config("winsdk_samples_config") {
- include_dirs = [
- baseclasses_dir,
- ]
+ include_dirs = [ baseclasses_dir ]
}
static_library("winsdk_samples") {
@@ -87,5 +85,25 @@ if (is_win) {
"//build/config/win:nominmax",
]
configs += [ "//build/config/compiler:no_chromium_code" ]
+ if (is_win && is_clang) {
+ cflags += [
+ # Disable warnings failing when compiling with Clang on Windows.
+ # https://bugs.chromium.org/p/webrtc/issues/detail?id=5366
+ "-Wno-comment",
+ "-Wno-delete-non-virtual-dtor",
+ "-Wno-ignored-attributes",
+ "-Wno-logical-op-parentheses",
+ "-Wno-non-pod-varargs",
+ "-Wno-microsoft-extra-qualification",
+ "-Wno-missing-braces",
+ "-Wno-overloaded-virtual",
+ "-Wno-parentheses",
+ "-Wno-reorder",
+ "-Wno-string-conversion",
+ "-Wno-tautological-constant-out-of-range-compare",
+ "-Wno-unused-private-field",
+ "-Wno-writable-strings",
+ ]
+ }
}
-}
+}
« no previous file with comments | « .gn ('k') | webrtc/base/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698