Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Issue 2273783004: GN build rules for four audio processing test executables (Closed)

Created:
4 years, 4 months ago by kwiberg-webrtc
Modified:
4 years, 3 months ago
CC:
webrtc-reviews_webrtc.org, peah-webrtc, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

GN build rules for four audio processing test executables click_annotate, intelligibility_proc, nonlinear_beamformer_test, and transient_suppression_test. This is a re-land of https://codereview.webrtc.org/2267403003 BUG=webrtc:5949 Committed: https://crrev.com/7a770e0a61cb9bf823691e5858b13ef3319ee69a Cr-Commit-Position: refs/heads/master@{#13913}

Patch Set 1 : patch from original CL #

Patch Set 2 : Let each test binary depend on metrics_default instead #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -0 lines) Patch
M webrtc/modules/audio_processing/BUILD.gn View 1 1 chunk +69 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
kwiberg-webrtc
Tested manually in Chromium; the original CL breaks, but patch set #2 succeeds.
4 years, 3 months ago (2016-08-24 21:51:23 UTC) #2
kjellander_webrtc
lgtm These metrics/field_trial default targets are of tricky. I guess we should do those targets ...
4 years, 3 months ago (2016-08-25 08:47:01 UTC) #3
aleloi
lgtm lgtm
4 years, 3 months ago (2016-08-25 08:49:36 UTC) #4
kwiberg-webrtc
On 2016/08/25 08:47:01, kjellander_webrtc wrote: > lgtm > > These metrics/field_trial default targets are of ...
4 years, 3 months ago (2016-08-25 09:03:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2273783004/20001
4 years, 3 months ago (2016-08-25 09:03:52 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-08-25 09:32:49 UTC) #8
commit-bot: I haz the power
4 years, 3 months ago (2016-08-25 09:33:46 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7a770e0a61cb9bf823691e5858b13ef3319ee69a
Cr-Commit-Position: refs/heads/master@{#13913}

Powered by Google App Engine
This is Rietveld 408576698